jenkins-bot has submitted this change and it was merged.
Change subject: fixing property param in api wbgetclaims
......................................................................
fixing property param in api wbgetclaims
Bug: 50061
Change-Id: I96be917aca5bcd1a191a433b6adf1dd7aaf592b9
---
M repo/includes/api/GetClaims.php
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/api/GetClaims.php b/repo/includes/api/GetClaims.php
index 1c71a93..3b3f572 100644
--- a/repo/includes/api/GetClaims.php
+++ b/repo/includes/api/GetClaims.php
@@ -6,11 +6,14 @@
use MWException;
use Wikibase\Lib\ClaimGuidValidator;
+use Wikibase\Lib\EntityIdFormatter;
+use Wikibase\Lib\EntityIdParser;
use Wikibase\Lib\Serializers\ClaimSerializer;
use Wikibase\Lib\Serializers\SerializerFactory;
use Wikibase\EntityId;
use Wikibase\Entity;
use Wikibase\EntityContentFactory;
+use Wikibase\Property;
use Wikibase\Statement;
use Wikibase\Claims;
use Wikibase\Claim;
@@ -129,7 +132,7 @@
$claims = array();
$params = $this->extractRequestParams();
- // TODO: we probably need this elswhere, so make filter methods
in Claim
+ // TODO: we probably need this elsewhere, so make filter
methods in Claim
$rank = isset( $params['rank'] ) ?
ClaimSerializer::unserializeRank( $params['rank'] ) : false;
$propertyId = isset( $params['property'] ) ?
$params['property'] : false;
@@ -141,7 +144,7 @@
|| ( $claim instanceof Statement &&
$claim->getRank() === $rank );
if ( $rankIsOk
- && ( $propertyId === false || $propertyId ===
$claim->getPropertyId() ) ) {
+ && ( $propertyId === false || $propertyId ===
$claim->getPropertyId()->getPrefixedId() ) ) {
$claims[] = $claim;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/72319
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96be917aca5bcd1a191a433b6adf1dd7aaf592b9
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Bene <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Daniel Werner <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
