Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/72532
Change subject: use EntityIdParser instead of getPrefixedId
......................................................................
use EntityIdParser instead of getPrefixedId
Bug: 50061
Change-Id: Ic8c389a627d82ac48aa31003b3d8b38aa4340b94
---
M repo/includes/api/GetClaims.php
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/32/72532/1
diff --git a/repo/includes/api/GetClaims.php b/repo/includes/api/GetClaims.php
index 15de320..595a69c 100644
--- a/repo/includes/api/GetClaims.php
+++ b/repo/includes/api/GetClaims.php
@@ -133,7 +133,9 @@
// TODO: we probably need this elsewhere, so make filter
methods in Claim
$rank = isset( $params['rank'] ) ?
ClaimSerializer::unserializeRank( $params['rank'] ) : false;
- $propertyId = isset( $params['property'] ) ?
$params['property'] : false;
+ $entityIdParser =
WikibaseRepo::getDefaultInstance()->getEntityIdParser();
+ /** @var $propertyId EntityId */
+ $propertyId = isset( $params['property'] ) ?
$entityIdParser->parse( $params['property'] ) : false;
/**
* @var \Wikibase\Claim $claim
@@ -143,7 +145,7 @@
|| ( $claim instanceof Statement &&
$claim->getRank() === $rank );
if ( $rankIsOk
- && ( $propertyId === false || $propertyId ===
$claim->getPropertyId()->getPrefixedId() ) ) {
+ && ( $propertyId === false ||
$claim->getPropertyId()->equals($propertyId) ) ) {
$claims[] = $claim;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/72532
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8c389a627d82ac48aa31003b3d8b38aa4340b94
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
