GWicke has uploaded a new change for review.
https://gerrit.wikimedia.org/r/72629
Change subject: Handle absent dp.sa in DU.getAttributeShadowInfo
......................................................................
Handle absent dp.sa in DU.getAttributeShadowInfo
This happens where only shadowing (without setting a normalized value) was
used, and led to a crash in rt testing.
Change-Id: I78c5e75553eebb0fd854be161b4c2334026c041b
---
M js/lib/mediawiki.DOMUtils.js
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid
refs/changes/29/72629/1
diff --git a/js/lib/mediawiki.DOMUtils.js b/js/lib/mediawiki.DOMUtils.js
index 36ca2e1..0d0b0b2 100644
--- a/js/lib/mediawiki.DOMUtils.js
+++ b/js/lib/mediawiki.DOMUtils.js
@@ -189,6 +189,12 @@
modified: true,
fromsrc: false
};
+ } else if ( dp.sa === undefined ) {
+ return {
+ value: curVal,
+ modified: false,
+ fromsrc: false
+ };
} else {
return {
value: dp.sa[name],
--
To view, visit https://gerrit.wikimedia.org/r/72629
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78c5e75553eebb0fd854be161b4c2334026c041b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
