jenkins-bot has submitted this change and it was merged.
Change subject: mw.ViewPageTarget.init: Only bind edit section links on view
page
......................................................................
mw.ViewPageTarget.init: Only bind edit section links on view page
The handler for the Edit tab already is in this conditional,
for edit section we were making the assumption that they only
ever appear on a view page, but that's wrong. They're also shown
on a diff against the latest revision of the page.
Bug: 50925
Change-Id: I802e548cbcdc03cfca66129466668854604bc3e7
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
index 575436c..0b0cd59 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
@@ -247,7 +247,14 @@
// Events
$heading.on( { 'mouseenter': expandSoon,
'mouseleave': shrinkSoon } );
$links.on( { 'focus': expand, 'blur':
shrinkSoon } );
- $editLink.click( init.onEditSectionLinkClick );
+ if ( isViewPage ) {
+ // Only init without refresh if we're
on a view page. Though section edit links
+ // are rarely shown on non-view pages,
they appear in one other case, namely
+ // when on a diff against the latest
version of a page. In that case we mustn't
+ // init without refresh as that'd
initialise for the wrong rev id (bug 50925)
+ // and would preserve the wrong DOM
with a diff on top.
+ $editLink.click(
init.onEditSectionLinkClick );
+ }
// Initialization
$editSourceLink
--
To view, visit https://gerrit.wikimedia.org/r/72544
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I802e548cbcdc03cfca66129466668854604bc3e7
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
