Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/72675
Change subject: Blacklist Firefox 13 and 14 too
......................................................................
Blacklist Firefox 13 and 14 too
Firefox 13 and 14 were the cause of links magically turning into [[./Foo]].
Once the immediate rush of deployment is over, we'll want to investigate as
to why and hopefully find a way to unblacklist FF.
Bug: 50720
Change-Id: I7a9dddb693091fa1e44b4325e77b9e4f55e5c193
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
M modules/ve-mw/test/init/targets/ve.init.mw.ViewPageTarget.test.js
3 files changed, 13 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/75/72675/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
index 0b0cd59..7e40fd5 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
@@ -89,8 +89,8 @@
'msie': [['<=', 10]],
// Android 2.x and below "support" CE but don't trigger
keyboard input
'android': [['<', 3]],
- // Bug 50780 - apparently Firefox is broken in versions
12 and below
- 'firefox': [['<=', 12]],
+ // Bug 50720 - apparently Firefox is broken in versions
14 and below
+ 'firefox': [['<=', 14]],
// Blacklist all versions:
'opera': null,
'blackberry': null
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index 1aed07e..e3856d8 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -155,7 +155,7 @@
// The value is either null (match all versions) or a list of tuples
// containing an inequality (<,>,<=,>=) and a version number
'whitelist': {
- 'firefox': [['>=', 13]],
+ 'firefox': [['>=', 15]],
'iceweasel': [['>=', 10]],
'safari': [['>=', 5]],
'chrome': [['>=', 19]]
diff --git a/modules/ve-mw/test/init/targets/ve.init.mw.ViewPageTarget.test.js
b/modules/ve-mw/test/init/targets/ve.init.mw.ViewPageTarget.test.js
index d58772d..244a475 100644
--- a/modules/ve-mw/test/init/targets/ve.init.mw.ViewPageTarget.test.js
+++ b/modules/ve-mw/test/init/targets/ve.init.mw.ViewPageTarget.test.js
@@ -54,6 +54,16 @@
{
'msg': 'Firefox 13',
'userAgent': 'Mozilla/5.0 (X11; Ubuntu; Linux
x86_64; rv:13.0) Gecko/20100101 Firefox/13.0',
+ 'matches': [ 'blacklist' ]
+ },
+ {
+ 'msg': 'Firefox 14',
+ 'userAgent': 'Mozilla/5.0 (Windows NT 6.1;
rv:12.0) Gecko/20120403211507 Firefox/14.0.1',
+ 'matches': [ 'blacklist' ]
+ },
+ {
+ 'msg': 'Firefox 15',
+ 'userAgent': 'Mozilla/5.0 (X11; Ubuntu; Linux
i686; rv:15.0) Gecko/20100101 Firefox/15.0.1',
'matches': [ 'whitelist' ]
},
{
--
To view, visit https://gerrit.wikimedia.org/r/72675
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a9dddb693091fa1e44b4325e77b9e4f55e5c193
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
