jenkins-bot has submitted this change and it was merged.

Change subject: Cosmetic: Minor cleanup.
......................................................................


Cosmetic: Minor cleanup.

Change-Id: Iedbbf3fa9ad417d77f588442aebbab860c24a2d6
---
M js/lib/mediawiki.DOMPostProcessor.js
1 file changed, 14 insertions(+), 14 deletions(-)

Approvals:
  GWicke: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/js/lib/mediawiki.DOMPostProcessor.js 
b/js/lib/mediawiki.DOMPostProcessor.js
index e11ef23..0ecc24a 100644
--- a/js/lib/mediawiki.DOMPostProcessor.js
+++ b/js/lib/mediawiki.DOMPostProcessor.js
@@ -2931,26 +2931,26 @@
                this.processors.push(encapsulateTemplateOutput);
        }
 
-       // DOM traverser for passes that can be combined and will run at the end
        // 1. Link prefixes and suffixes
-       // 2. Strip marker metas -- removes left over marker metas (ex: metas
-       //    nested in expanded tpl/extension output).
-       // 3. Unpack DOM fragments (reused transclusion and extension content)
-       var lastDOMHandler = new DOMTraverser();
-       lastDOMHandler.addHandler( 'a', handleLinkNeighbours.bind( null, env ) 
);
-       lastDOMHandler.addHandler( null, unpackDOMFragments.bind(null, env) );
-       this.processors.push(lastDOMHandler.traverse.bind(lastDOMHandler));
+       // 2. Unpack DOM fragments (reused transclusion and extension content)
+       var domVisitor1 = new DOMTraverser();
+       domVisitor1.addHandler( 'a', handleLinkNeighbours.bind( null, env ) );
+       domVisitor1.addHandler( null, unpackDOMFragments.bind(null, env) );
+       this.processors.push(domVisitor1.traverse.bind(domVisitor1));
 
        // A pure DOM transformation
        this.processors.push(generateReferences.bind(null,
                                
env.conf.parsoid.nativeExtensions.cite.references));
 
-       var dataParsoidSaver = new DOMTraverser();
-
-       dataParsoidSaver.addHandler( 'meta', stripMarkerMetas.bind(null, 
env.conf.parsoid.editMode) );
-       dataParsoidSaver.addHandler( 'li', cleanUpLIHack.bind( null, env ) );
-       dataParsoidSaver.addHandler( null, saveDataParsoid );
-       this.processors.push(dataParsoidSaver.traverse.bind(dataParsoidSaver));
+       // 1. Strip marker metas -- removes left over marker metas (ex: metas
+       //    nested in expanded tpl/extension output).
+       // 2. Fix up DOM for li-hack.
+       // 3. Save data.parsoid into data-parsoid html attribute.
+       var domVisitor2 = new DOMTraverser();
+       domVisitor2.addHandler( 'meta', stripMarkerMetas.bind(null, 
env.conf.parsoid.editMode) );
+       domVisitor2.addHandler( 'li', cleanUpLIHack.bind( null, env ) );
+       domVisitor2.addHandler( null, saveDataParsoid );
+       this.processors.push(domVisitor2.traverse.bind(domVisitor2));
 }
 
 // Inherit from EventEmitter

-- 
To view, visit https://gerrit.wikimedia.org/r/72636
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iedbbf3fa9ad417d77f588442aebbab860c24a2d6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to