Rfaulk has submitted this change and it was merged.
Change subject: mod/fix. raise exceptions on abstract class method calls/pep8
......................................................................
mod/fix. raise exceptions on abstract class method calls/pep8
Change-Id: I5b763793cd7b8db0fb17d555c9a81a6720e24285
---
M user_metrics/api/broker.py
1 file changed, 11 insertions(+), 7 deletions(-)
Approvals:
Rfaulk: Verified; Looks good to me, approved
diff --git a/user_metrics/api/broker.py b/user_metrics/api/broker.py
index 411b4b9..72e97a1 100644
--- a/user_metrics/api/broker.py
+++ b/user_metrics/api/broker.py
@@ -9,19 +9,23 @@
__date__ = "2013-07-06"
__license__ = "GPL (version 2 or later)"
-class Broker:
- def __init__(self):
- pass
+class Broker(object):
+ """
+ Base class for broker
+ """
+
+ def __init__(self, **kwargs):
+ raise NotImplementedError()
def compose(self):
- pass
+ raise NotImplementedError()
def add(self, target, key, value):
- pass
+ raise NotImplementedError()
def remove(self, target, key):
- pass
+ raise NotImplementedError()
def get(self, target, key):
- pass
+ raise NotImplementedError()
--
To view, visit https://gerrit.wikimedia.org/r/72688
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b763793cd7b8db0fb17d555c9a81a6720e24285
Gerrit-PatchSet: 1
Gerrit-Project: analytics/user-metrics
Gerrit-Branch: repair_runtime
Gerrit-Owner: Rfaulk <[email protected]>
Gerrit-Reviewer: Rfaulk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
