Rfaulk has submitted this change and it was merged.
Change subject: add. remove functionality.
......................................................................
add. remove functionality.
Change-Id: I59779882310708f7c1e31c5238a1848fe522ed62
---
M user_metrics/api/broker.py
1 file changed, 13 insertions(+), 1 deletion(-)
Approvals:
Rfaulk: Verified; Looks good to me, approved
diff --git a/user_metrics/api/broker.py b/user_metrics/api/broker.py
index 35243d8..fc4c3f1 100644
--- a/user_metrics/api/broker.py
+++ b/user_metrics/api/broker.py
@@ -68,7 +68,19 @@
f.write(json.dumps({key: value}) + '\n')
def remove(self, target, key):
- pass
+ """
+ Remove element with the given key
+ """
+ with open(target, 'r') as f:
+ lines = f.read().split('\n')
+ for idx, line in enumerate(lines):
+ item = json.loads(line)
+ if item['key'] == key:
+ del lines[idx]
+ break
+ with open(target, 'w') as f:
+ for line in lines:
+ f.write(line)
def get(self, target, key):
pass
--
To view, visit https://gerrit.wikimedia.org/r/72694
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59779882310708f7c1e31c5238a1848fe522ed62
Gerrit-PatchSet: 1
Gerrit-Project: analytics/user-metrics
Gerrit-Branch: repair_runtime
Gerrit-Owner: Rfaulk <[email protected]>
Gerrit-Reviewer: Rfaulk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
