Denny Vrandecic has submitted this change and it was merged.
Change subject: Optimized imports
......................................................................
Optimized imports
Change-Id: I40d48a0935981e49c8ca97c95b0ad45c05373314
---
M src/Ask/Deserializers/DescriptionDeserializer.php
A src/Ask/Deserializers/QueryOptionsDeserializer.php
M src/Ask/Deserializers/SortExpressionDeserializer.php
M src/Ask/Deserializers/TypedObjectDeserializer.php
M src/Ask/Serializers/QuerySerializer.php
M src/Ask/Serializers/SelectionRequestSerializer.php
6 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Denny Vrandecic: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/Ask/Deserializers/DescriptionDeserializer.php
b/src/Ask/Deserializers/DescriptionDeserializer.php
index 553b25d..a296498 100644
--- a/src/Ask/Deserializers/DescriptionDeserializer.php
+++ b/src/Ask/Deserializers/DescriptionDeserializer.php
@@ -4,15 +4,12 @@
use Ask\Deserializers\Exceptions\DeserializationException;
use Ask\Deserializers\Exceptions\InvalidAttributeException;
-use Ask\Deserializers\Exceptions\MissingAttributeException;
-use Ask\Deserializers\Exceptions\MissingTypeException;
use Ask\Language\Description\AnyValue;
use Ask\Language\Description\Conjunction;
use Ask\Language\Description\Description;
use Ask\Language\Description\Disjunction;
use Ask\Language\Description\SomeProperty;
use Ask\Language\Description\ValueDescription;
-use Ask\Deserializers\Exceptions\UnsupportedTypeException;
use DataValues\DataValueFactory;
/**
diff --git a/src/Ask/Deserializers/QueryOptionsDeserializer.php
b/src/Ask/Deserializers/QueryOptionsDeserializer.php
new file mode 100644
index 0000000..1388bd5
--- /dev/null
+++ b/src/Ask/Deserializers/QueryOptionsDeserializer.php
@@ -0,0 +1,8 @@
+<?php
+/**
+ * Created by JetBrains PhpStorm.
+ * User: j
+ * Date: 09/07/13
+ * Time: 12:07
+ * To change this template use File | Settings | File Templates.
+ */
\ No newline at end of file
diff --git a/src/Ask/Deserializers/SortExpressionDeserializer.php
b/src/Ask/Deserializers/SortExpressionDeserializer.php
index cf388cc..34b506c 100644
--- a/src/Ask/Deserializers/SortExpressionDeserializer.php
+++ b/src/Ask/Deserializers/SortExpressionDeserializer.php
@@ -4,9 +4,6 @@
use Ask\Deserializers\Exceptions\DeserializationException;
use Ask\Deserializers\Exceptions\InvalidAttributeException;
-use Ask\Deserializers\Exceptions\MissingAttributeException;
-use Ask\Deserializers\Exceptions\MissingTypeException;
-use Ask\Deserializers\Exceptions\UnsupportedTypeException;
use Ask\Language\Option\PropertyValueSortExpression;
use DataValues\DataValueFactory;
use InvalidArgumentException;
diff --git a/src/Ask/Deserializers/TypedObjectDeserializer.php
b/src/Ask/Deserializers/TypedObjectDeserializer.php
index 98faa16..e16a793 100644
--- a/src/Ask/Deserializers/TypedObjectDeserializer.php
+++ b/src/Ask/Deserializers/TypedObjectDeserializer.php
@@ -81,7 +81,7 @@
protected function getDeserialization( array $serialization ) {
$this->requireAttribute( $serialization, $this->getSubTypeKey()
);
- $this->requireAttribute( $serialization, 'value' );
+ $this->requireAttributes( $serialization, 'value' );
$this->assertAttributeIsArray( $serialization, 'value' );
$specificType = $serialization[$this->getSubTypeKey()];
diff --git a/src/Ask/Serializers/QuerySerializer.php
b/src/Ask/Serializers/QuerySerializer.php
index 93138c6..3073a05 100644
--- a/src/Ask/Serializers/QuerySerializer.php
+++ b/src/Ask/Serializers/QuerySerializer.php
@@ -3,7 +3,6 @@
namespace Ask\Serializers;
use Ask\Language\Query;
-use Ask\Language\Selection\SelectionRequest;
use Ask\Serializers\Exceptions\UnsupportedObjectException;
/**
diff --git a/src/Ask/Serializers/SelectionRequestSerializer.php
b/src/Ask/Serializers/SelectionRequestSerializer.php
index dbbf972..0f86c2c 100644
--- a/src/Ask/Serializers/SelectionRequestSerializer.php
+++ b/src/Ask/Serializers/SelectionRequestSerializer.php
@@ -2,7 +2,6 @@
namespace Ask\Serializers;
-use Ask\Language\Option\QueryOptions;
use Ask\Language\Selection\PropertySelection;
use Ask\Language\Selection\SelectionRequest;
use Ask\Language\Selection\SubjectSelection;
--
To view, visit https://gerrit.wikimedia.org/r/72714
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40d48a0935981e49c8ca97c95b0ad45c05373314
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Ask
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Denny Vrandecic <denny.vrande...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
