Yaron Koren has submitted this change and it was merged.
Change subject: Allow array params
......................................................................
Allow array params
Change-Id: I58aa2009015227219b4ad12faffe110571a45eaf
---
M UrlGetParameters.php
1 file changed, 15 insertions(+), 2 deletions(-)
Approvals:
Yaron Koren: Verified; Looks good to me, approved
Objections:
Daniel Werner: There's a problem with this change, please improve
diff --git a/UrlGetParameters.php b/UrlGetParameters.php
index 5cbfcef..a120a45 100644
--- a/UrlGetParameters.php
+++ b/UrlGetParameters.php
@@ -14,6 +14,8 @@
$wgHooks['ParserFirstCallInit'][] = 'urlGetParameters_Setup';
+$wgUrlGetParametersSeparator = ",";
+
/**
* @param $parser Parser
* @return void
@@ -28,6 +30,8 @@
* @return string
*/
function urlGetParameters_Render( $parser ) {
+ global $wgUrlGetParametersSeparator;
+
// {{#urlget:paramname|defaultvalue}}
// Get the parameters that were passed to this function
@@ -42,9 +46,18 @@
$pos_right_bracket = strpos( $params[0], ']' );
if ( !$pos_left_bracket || !$pos_right_bracket ) {
- // Not an array
+
if ( isset($_GET[$params[0]] ) ) {
- return rawurlencode( $_GET[$params[0]] );
+ // Allow array
+ if ( is_array( $_GET[$params[0]] ) ) {
+ $listval = array();
+ foreach ($_GET[$params[0]] as $selectedOption) {
+ array_push( $listval, rawurlencode(
$selectedOption ) );
+ }
+ return implode($wgUrlGetParametersSeparator,
$listval);
+ } else {
+ return rawurlencode( $_GET[$params[0]] );
+ }
}
} else {
// It's an array
--
To view, visit https://gerrit.wikimedia.org/r/25734
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I58aa2009015227219b4ad12faffe110571a45eaf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UrlGetParameters
Gerrit-Branch: master
Gerrit-Owner: Toniher <[email protected]>
Gerrit-Reviewer: Daniel Werner <[email protected]>
Gerrit-Reviewer: Yaron Koren <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
