jenkins-bot has submitted this change and it was merged.

Change subject: Prevent cutting off license image
......................................................................


Prevent cutting off license image

On big screens when license text is only a single line.

Change-Id: I3cb28545d6cfd9a969c3496b8fbfde949cb8decb
---
M less/common/overlays.less
M stylesheets/common/overlays.css
2 files changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Jdlrobson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/less/common/overlays.less b/less/common/overlays.less
index ba65c1a..3cfece5 100644
--- a/less/common/overlays.less
+++ b/less/common/overlays.less
@@ -118,12 +118,14 @@
 
                .license {
                        // FIXME: move this image?
-                       background: url('../modules/images/cc-by-sa.png') 0 
.2em no-repeat;
+                       background: url('../modules/images/cc-by-sa.png') 0 2px 
no-repeat;
                        background-size: auto 16px;
                        padding: 0 0 0 55px;
                        margin-bottom: 1.2em;
                        color: #707070;
                        font-size: .75em !important;
+                       // if license is only one line (big screens) prevent 
cutting off the image
+                       min-height: 18px;
                }
        }
 
diff --git a/stylesheets/common/overlays.css b/stylesheets/common/overlays.css
index 4dffa93..094c6d3 100644
--- a/stylesheets/common/overlays.css
+++ b/stylesheets/common/overlays.css
@@ -100,12 +100,13 @@
   text-align: left;
 }
 .mw-mf-overlay .buttonBar .license {
-  background: url('../modules/images/cc-by-sa.png') 0 0.2em no-repeat;
+  background: url('../modules/images/cc-by-sa.png') 0 2px no-repeat;
   background-size: auto 16px;
   padding: 0 0 0 55px;
   margin-bottom: 1.2em;
   color: #707070;
   font-size: .75em !important;
+  min-height: 18px;
 }
 .mw-mf-overlay .mw-mf-overlay-footer,
 .mw-mf-overlay .mw-mf-overlay-header {

-- 
To view, visit https://gerrit.wikimedia.org/r/72668
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3cb28545d6cfd9a969c3496b8fbfde949cb8decb
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to