Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/73316
Change subject: Entity removeAliases now resets array keys
......................................................................
Entity removeAliases now resets array keys
Bug: 51192
Change-Id: Iabbc7123378de1c1408ba95e262db947eef64239
---
M DataModel/Entity/Entity.php
1 file changed, 3 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseDataModel
refs/changes/16/73316/1
diff --git a/DataModel/Entity/Entity.php b/DataModel/Entity/Entity.php
index c9e02af..e697bde 100644
--- a/DataModel/Entity/Entity.php
+++ b/DataModel/Entity/Entity.php
@@ -386,10 +386,11 @@
public function removeAliases( $languageCode, array $aliases ) {
$this->setAliases(
$languageCode,
- array_diff(
+ array_values(
+ array_diff(
$this->getAliases( $languageCode ),
$aliases
- )
+ ) )
);
}
--
To view, visit https://gerrit.wikimedia.org/r/73316
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabbc7123378de1c1408ba95e262db947eef64239
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDataModel
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
