jenkins-bot has submitted this change and it was merged.

Change subject: Cleaning up some old bogus CSS
......................................................................


Cleaning up some old bogus CSS

Bug: 51069
Change-Id: I78c640f59ab7e2501322aeb4c16aab96436890e3
---
M less/common/overlays.less
M stylesheets/common/overlays.css
2 files changed, 27 insertions(+), 45 deletions(-)

Approvals:
  Jdlrobson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/less/common/overlays.less b/less/common/overlays.less
index 3cfece5..d4746dd 100644
--- a/less/common/overlays.less
+++ b/less/common/overlays.less
@@ -1,28 +1,5 @@
 @import "../mf-mixins.less";
 
-// FIXME: this looks suspicious (overlay class is added to <html>)
-.overlay ul {
-       text-align: left;
-       left: 0;
-       border: none;
-       z-index: 1;
-       position: relative;
-       opacity: 1;
-       padding: 0;
-       margin: 0;
-       list-style: none;
-
-       &.informative {
-               margin-left: 16px;
-               list-style: outside square;
-               margin-bottom: 16px;
-
-               li {
-                       margin-bottom: 8px;
-               }
-       }
-}
-
 html.overlay {
        .mw-mf-overlay {
                display: block;
@@ -76,8 +53,21 @@
                background-color: #F1F1F1;
        }
 
-       li {
-               text-align: left;
+       ul {
+               list-style: none;
+               li {
+                       text-align: left;
+               }
+
+               &.informative {
+                       margin-left: 16px;
+                       list-style: outside square;
+                       margin-bottom: 16px;
+
+                       li {
+                               margin-bottom: 8px;
+                       }
+               }
        }
 
        // FIXME: talk overlay specific (style talk textarea like the editor)
diff --git a/stylesheets/common/overlays.css b/stylesheets/common/overlays.css
index 094c6d3..2661f97 100644
--- a/stylesheets/common/overlays.css
+++ b/stylesheets/common/overlays.css
@@ -5,25 +5,6 @@
  * Please edit the corresponding less file instead.
  * See README.mediawiki for details on installing.
  */
-.overlay ul {
-  text-align: left;
-  left: 0;
-  border: none;
-  z-index: 1;
-  position: relative;
-  opacity: 1;
-  padding: 0;
-  margin: 0;
-  list-style: none;
-}
-.overlay ul.informative {
-  margin-left: 16px;
-  list-style: outside square;
-  margin-bottom: 16px;
-}
-.overlay ul.informative li {
-  margin-bottom: 8px;
-}
 html.overlay .mw-mf-overlay {
   display: block;
 }
@@ -69,9 +50,20 @@
 .mw-mf-overlay .mw-mf-overlay-header {
   background-color: #F1F1F1;
 }
-.mw-mf-overlay li {
+.mw-mf-overlay ul {
+  list-style: none;
+}
+.mw-mf-overlay ul li {
   text-align: left;
 }
+.mw-mf-overlay ul.informative {
+  margin-left: 16px;
+  list-style: outside square;
+  margin-bottom: 16px;
+}
+.mw-mf-overlay ul.informative li {
+  margin-bottom: 8px;
+}
 .mw-mf-overlay div.content textarea {
   display: block;
   width: 100%;

-- 
To view, visit https://gerrit.wikimedia.org/r/73348
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I78c640f59ab7e2501322aeb4c16aab96436890e3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to