Milimetric has uploaded a new change for review.
https://gerrit.wikimedia.org/r/73516
Change subject: fixed redirect after creating a job
......................................................................
fixed redirect after creating a job
Change-Id: I2b19224a7f238575c6b331076668cff918ef09a1
---
M wikimetrics/controllers/jobs.py
1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/wikimetrics
refs/changes/16/73516/1
diff --git a/wikimetrics/controllers/jobs.py b/wikimetrics/controllers/jobs.py
index fb7e9b7..f6744ef 100644
--- a/wikimetrics/controllers/jobs.py
+++ b/wikimetrics/controllers/jobs.py
@@ -1,10 +1,10 @@
-from flask import render_template, request, jsonify
+from flask import render_template, request, url_for
from flask.ext.login import current_user
import celery
from ..configurables import app, db
from ..models import Cohort, Job, JobResponse, PersistentJob,
MultiProjectMetricJob
from ..metrics import metric_classes
-from ..utils import json_response
+from ..utils import json_response, json_redirect
import json
@@ -54,7 +54,7 @@
app.logger.info('starting job: %s', async_response.task_id)
#return render_template('jobs.html')
- return
jsonify(redirect_url='/jobs/status/{0}'.format(jr.persistent_id))
+ return json_redirect(url_for('jobs_index'))
@app.route('/jobs/list/')
@@ -62,7 +62,6 @@
db_session = db.get_session()
jobs = db_session.query(PersistentJob)\
.filter_by(user_id=current_user.id).all()
- app.logger.debug('jobs: %s', jobs)
# update status for each job
for job in jobs:
job.update_status()
@@ -81,4 +80,4 @@
db_job.status = celery_task.status
db_session.add(db_job)
db_session.commit()
- return jsonify(status=db_job.status)
+ return json_response(status=db_job.status)
--
To view, visit https://gerrit.wikimedia.org/r/73516
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b19224a7f238575c6b331076668cff918ef09a1
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wikimetrics
Gerrit-Branch: master
Gerrit-Owner: Milimetric <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
