Denny Vrandecic has submitted this change and it was merged.
Change subject: Revert "Log a warning if ItemChange::getSiteLinkDiff returns a
non-array"
......................................................................
Revert "Log a warning if ItemChange::getSiteLinkDiff returns a non-array"
This reverts commit 833cf2e85143717b92c7aa2f3b9c8b687230daaa.
Change-Id: I0d7b66dc4a8c738c76d2a413d0d451b0248ab631
---
M lib/maintenance/dispatchChanges.php
1 file changed, 1 insertion(+), 7 deletions(-)
Approvals:
Denny Vrandecic: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/maintenance/dispatchChanges.php
b/lib/maintenance/dispatchChanges.php
index 5ce791a..2573d63 100644
--- a/lib/maintenance/dispatchChanges.php
+++ b/lib/maintenance/dispatchChanges.php
@@ -855,13 +855,7 @@
if ( $change instanceof ItemChange && !$change->isEmpty() ) {
$siteLinkDiff = $change->getSiteLinkDiff();
- if ( !is_array( $siteLinkDiff ) ) {
- wfLogWarning( '$siteLinkDiff must be an array,
' . gettype( $siteLinkDiff ) . ' given' );
- wfProfileOut( __METHOD__ );
- return false;
- }
-
- if ( isset( $siteLinkDiff[ $siteID ] ) ) {
+ if ( is_array( $siteLinkDiff ) && isset( $siteLinkDiff[
$siteID ] ) ) {
wfProfileOut( __METHOD__ );
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/73574
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d7b66dc4a8c738c76d2a413d0d451b0248ab631
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Denny Vrandecic <denny.vrande...@wikimedia.de>
Gerrit-Reviewer: Denny Vrandecic <denny.vrande...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
