Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/73909
Change subject: Get rid of other clear() calls after change()
......................................................................
Get rid of other clear() calls after change()
The last thing change() does is emit unlock which calls clear(),
but at least sets the selection. There is no point in then clearing
completely, erasing the selection and needing Rangy to find the
selection again, which is a performance problem.
Change-Id: I2a0e27c83ddb4fe05e9fd5d2c45d032447d96e32
---
M modules/ve/ce/ve.ce.Surface.js
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/09/73909/1
diff --git a/modules/ve/ce/ve.ce.Surface.js b/modules/ve/ce/ve.ce.Surface.js
index 2d0778f..9bccdc5 100644
--- a/modules/ve/ce/ve.ce.Surface.js
+++ b/modules/ve/ce/ve.ce.Surface.js
@@ -571,7 +571,6 @@
tx = ve.dm.Transaction.newFromRemoval( this.documentView.model,
selection );
this.model.change( tx, new ve.Range( selection.start ) );
- this.surfaceObserver.clear();
this.surfaceObserver.start();
}, this ) );
};
@@ -1061,7 +1060,6 @@
ve.dm.Transaction.newFromRemoval(
this.documentView.model, selection ),
new ve.Range( selection.start )
);
- this.surfaceObserver.clear();
selection = this.model.getSelection();
this.model.setInsertionAnnotations( annotations );
}
@@ -1222,8 +1220,6 @@
null, new ve.Range(
documentModel.data.getNearestContentOffset( selection.from ) )
);
}
- // Reset and resume polling
- this.surfaceObserver.clear();
};
/**
@@ -1283,7 +1279,6 @@
);
}
this.model.change( null, new ve.Range( rangeToRemove.start ) );
- this.surfaceObserver.clear();
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/73909
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a0e27c83ddb4fe05e9fd5d2c45d032447d96e32
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
