Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/73949
Change subject: Log settings-open event
......................................................................
Log settings-open event
Change-Id: I55fb9e4b8b6b210003f6bbad07486e1c2a8cba4f
---
M resources/js/ext.uls.ime.js
M resources/js/ext.uls.interface.js
2 files changed, 14 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/49/73949/1
diff --git a/resources/js/ext.uls.ime.js b/resources/js/ext.uls.ime.js
index 8f16b81..56e05f7 100644
--- a/resources/js/ext.uls.ime.js
+++ b/resources/js/ext.uls.ime.js
@@ -123,6 +123,9 @@
$moreSettingsLink.languagesettings( {
defaultModule: 'input',
+ onVisible: function () {
+ mw.uls.logEvent( { action: 'settings-open',
context: 'menu' } );
+ },
onClose: function () {
// on close of input settings, keep focus in
input area.
imeselector.$element.focus();
diff --git a/resources/js/ext.uls.interface.js
b/resources/js/ext.uls.interface.js
index e1eba25..184a745 100644
--- a/resources/js/ext.uls.interface.js
+++ b/resources/js/ext.uls.interface.js
@@ -83,6 +83,7 @@
uls.$menu.find( '#settings-block' ).append( $displaySettings );
$displaySettings.languagesettings( displaySettingsOptions );
$displaySettings.on( 'click', function () {
+ mw.uls.logEvent( { action: 'settings-open', context:
'uls' } );
uls.hide();
} );
}
@@ -108,6 +109,7 @@
} );
$inputSettings.on( 'click', function () {
+ mw.uls.logEvent( { action: 'settings-open', context:
'uls' } );
uls.hide();
} );
}
@@ -352,10 +354,16 @@
this.top = ulsTriggerOffset.top
- topRowHeight - caretHeight / 2;
this.position();
+
+ mw.uls.logEvent( { action:
'settings-open', context: 'interlanguage' } );
}
} );
} else if ( anonMode ) {
- $ulsTrigger.languagesettings();
+ $ulsTrigger.languagesettings( {
+ onVisible: function () {
+ mw.uls.logEvent( { action:
'settings-open', context: 'personal' } );
+ }
+ } );
} else {
$ulsTrigger.uls( ulsOptions );
}
@@ -368,6 +376,8 @@
$( '#uls-preferences-link' )
.text( $.i18n(
'ext-uls-language-settings-preferences-link' ) )
.click( function () {
+ mw.uls.logEvent( { action:
'settings-open', context: 'preferences' } );
+
if ( $ulsTrigger.length ) {
$ulsTrigger.click();
} else {
--
To view, visit https://gerrit.wikimedia.org/r/73949
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55fb9e4b8b6b210003f6bbad07486e1c2a8cba4f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
