SuchABot has uploaded a new change for review. https://gerrit.wikimedia.org/r/73981
Change subject: [WIP] Initial move to Holo Light than Holo Dark ...................................................................... [WIP] Initial move to Holo Light than Holo Dark FIXME: Add better icons. Needs more work before it can be merged. Change-Id: Id046d4889b1ebb17dd225f15d56b17fb8fd36b1e GitHub: https://github.com/wikimedia/apps-android-commons/pull/29 --- M commons/res/layout/activity_contributions.xml M commons/res/layout/activity_share.xml M commons/res/layout/fragment_categorization.xml M commons/res/layout/fragment_contributions.xml M commons/res/layout/fragment_single_upload.xml M commons/res/layout/layout_contribution.xml M commons/res/layout/layout_upload_item.xml M commons/res/values-v14/styles.xml M commons/res/values/styles.xml 9 files changed, 10 insertions(+), 18 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/commons refs/changes/81/73981/1 diff --git a/commons/res/layout/activity_contributions.xml b/commons/res/layout/activity_contributions.xml index e1aba9b..1c695ae 100644 --- a/commons/res/layout/activity_contributions.xml +++ b/commons/res/layout/activity_contributions.xml @@ -5,7 +5,6 @@ android:layout_height="match_parent" android:orientation="horizontal" android:id="@+id/contributionsFragmentContainer" - android:background="#000000" > <fragment android:name="org.wikimedia.commons.contributions.ContributionsListFragment" diff --git a/commons/res/layout/activity_share.xml b/commons/res/layout/activity_share.xml index 4e73745..ddf9f30 100644 --- a/commons/res/layout/activity_share.xml +++ b/commons/res/layout/activity_share.xml @@ -1,15 +1,13 @@ -<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"; +<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"; android:layout_width="fill_parent" android:layout_height="fill_parent" - android:background="#000" + android:orientation="vertical" > - - <ImageView android:id="@+id/backgroundImage" android:layout_width="match_parent" - android:layout_height="fill_parent" + android:layout_height="144dp" android:scaleType="centerCrop" /> <FrameLayout @@ -18,4 +16,4 @@ android:layout_height="match_parent" /> -</FrameLayout> \ No newline at end of file +</LinearLayout> \ No newline at end of file diff --git a/commons/res/layout/fragment_categorization.xml b/commons/res/layout/fragment_categorization.xml index 900f868..2451cdd 100644 --- a/commons/res/layout/fragment_categorization.xml +++ b/commons/res/layout/fragment_categorization.xml @@ -4,7 +4,6 @@ android:orientation="vertical" android:layout_width="match_parent" android:layout_height="match_parent" - android:background="#AA000000" android:paddingBottom="8dip" android:paddingLeft="16dip" android:paddingStart="16dip" diff --git a/commons/res/layout/fragment_contributions.xml b/commons/res/layout/fragment_contributions.xml index 8019b54..8016204 100644 --- a/commons/res/layout/fragment_contributions.xml +++ b/commons/res/layout/fragment_contributions.xml @@ -4,7 +4,6 @@ android:orientation="vertical" android:layout_width="fill_parent" android:layout_height="fill_parent" - android:background="#000000" > <TextView android:layout_width="wrap_content" diff --git a/commons/res/layout/fragment_single_upload.xml b/commons/res/layout/fragment_single_upload.xml index a11df61..8f4909b 100644 --- a/commons/res/layout/fragment_single_upload.xml +++ b/commons/res/layout/fragment_single_upload.xml @@ -5,7 +5,6 @@ android:layout_height="match_parent" android:layout_gravity="fill" android:orientation="vertical" - android:background="#AA000000" android:paddingBottom="8dip" android:paddingLeft="16dip" android:paddingStart="16dip" diff --git a/commons/res/layout/layout_contribution.xml b/commons/res/layout/layout_contribution.xml index fdfe42f..ff1bf6c 100644 --- a/commons/res/layout/layout_contribution.xml +++ b/commons/res/layout/layout_contribution.xml @@ -5,7 +5,6 @@ android:orientation="vertical" android:layout_width="fill_parent" android:layout_height="wrap_content" - android:padding="2dp" android:paddingBottom="0dp" > @@ -13,9 +12,10 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:textSize="98sp" - android:textColor="#33FFFFFF" - android:typeface="serif" + android:textColor="#FFCCCCCC" + android:typeface="sans" android:layout_gravity="end|bottom" + /> <org.wikimedia.commons.MediaWikiImageView android:id="@+id/contributionImage" android:layout_width="fill_parent" diff --git a/commons/res/layout/layout_upload_item.xml b/commons/res/layout/layout_upload_item.xml index 1440be2..99827e5 100644 --- a/commons/res/layout/layout_upload_item.xml +++ b/commons/res/layout/layout_upload_item.xml @@ -6,7 +6,6 @@ android:layout_height="wrap_content" android:padding="2dp" android:paddingBottom="0dp" - android:background="#000000" > <ImageView android:id="@+id/uploadImage" android:layout_width="fill_parent" @@ -20,7 +19,6 @@ android:layout_height="wrap_content" android:layout_gravity="center|bottom" android:background="#77000000" - android:padding="4dp" > <TextView diff --git a/commons/res/values-v14/styles.xml b/commons/res/values-v14/styles.xml index 28e2772..21b3958 100644 --- a/commons/res/values-v14/styles.xml +++ b/commons/res/values-v14/styles.xml @@ -1,6 +1,6 @@ <resources> - <style name="ProgressBar" parent="android:Widget.Holo.ProgressBar.Horizontal" /> - <style name="AppTheme" parent="android:Theme.Holo" /> + <style name="ProgressBar" parent="android:Widget.Holo.Light.ProgressBar.Horizontal" /> + <style name="AppTheme" parent="android:Theme.Holo.Light" /> </resources> \ No newline at end of file diff --git a/commons/res/values/styles.xml b/commons/res/values/styles.xml index 84c89ee..ca0273e 100644 --- a/commons/res/values/styles.xml +++ b/commons/res/values/styles.xml @@ -1,6 +1,6 @@ <resources> - <style name="AppTheme" parent="Theme.Sherlock" /> + <style name="AppTheme" parent="Theme.Sherlock.Light" /> <style name="NoTitle" parent="AppTheme"> <item name="android:windowNoTitle">true</item> -- To view, visit https://gerrit.wikimedia.org/r/73981 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id046d4889b1ebb17dd225f15d56b17fb8fd36b1e Gerrit-PatchSet: 1 Gerrit-Project: apps/android/commons Gerrit-Branch: master Gerrit-Owner: SuchABot <[email protected]> Gerrit-Reviewer: Yuvipanda <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
