jenkins-bot has submitted this change and it was merged.

Change subject: Clear aliases when setting all aliases
......................................................................


Clear aliases when setting all aliases

Tests to come in a followup

Change-Id: I668d8eccb40ef7f384d03657fe4f5a1da4f017fc
---
M DataModel/Entity/Entity.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Daniel Kinzler: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/DataModel/Entity/Entity.php b/DataModel/Entity/Entity.php
index d3cfc5f..262fb55 100644
--- a/DataModel/Entity/Entity.php
+++ b/DataModel/Entity/Entity.php
@@ -524,8 +524,9 @@
         * @param array[] $aliasLists
         */
        public function setAllAliases( array $aliasLists ) {
+               $this->data['aliases'] = array();
                foreach( $aliasLists as $languageCode => $aliasList ){
-                       $this->setAliases($languageCode, $aliasList);
+                       $this->setAliases( $languageCode, $aliasList );
                }
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/73968
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I668d8eccb40ef7f384d03657fe4f5a1da4f017fc
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikibaseDataModel
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to