Marcoil has uploaded a new change for review.
https://gerrit.wikimedia.org/r/73985
Change subject: Correctly record crashing titles as errors after a number of
retries.
......................................................................
Correctly record crashing titles as errors after a number of retries.
Bug #44652
Change-Id: Ib882ba4ece08533e645e3eba6e9a78138f6c2787
---
M js/tests/server/server.js
1 file changed, 12 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid
refs/changes/85/73985/1
diff --git a/js/tests/server/server.js b/js/tests/server/server.js
index 5c24e29..17bb75e 100755
--- a/js/tests/server/server.js
+++ b/js/tests/server/server.js
@@ -432,13 +432,21 @@
if (claim[0].num_tries >= maxTries) {
// Too many failures. Insert an error
stats entry and retry fetch
console.log( ' CRASHER?', row[0].prefix
+ ':' + row[0].title );
- var stats = [0, 0, 1,
statsScore(0,0,1), claim[0].page_id, commitHash];
+ var stats = [0, 0, 1,
statsScore(0,0,1), row[0].id, commitHash];
db.query( dbInsertClaimStats, stats,
function ( err ) {
- if (err) {
+ if ( !err ) {
+ db.query(
dbUpdateLatestResult, [commitHash, row[0].id],
+
dbUpdateErrCB.bind(null, row[0].title, row[0].prefix, commitHash, 'latest
result', null ) );
+ } else {
// Try updating the
stats instead of inserting if we got an error
// Likely a sql
constraint error
db.query(
dbUpdateClaimStats, stats, function (err) {
- dbUpdateErrCB(
row[0].title, row[0].prefix, commitHash, 'stats', null, err );
+ if ( !err ) {
+
db.query( dbUpdateLatestResult, [commitHash, row[0].id],
+
dbUpdateErrCB.bind(null, row[0].title, row[0].prefix, commitHash, 'latest
result', null ) );
+ } else {
+
dbUpdateErrCB( row[0].title, row[0].prefix, commitHash, 'stats', null, err );
+ }
});
}
} );
@@ -831,7 +839,7 @@
if ( err ) {
console.error( err );
res.send( err.toString(), 500 );
- } else if ( row ) {
+ } else if ( row && row.length > 0 ) {
res.setHeader( 'Content-Type', 'text/xml; charset=UTF-8' );
res.status( 200 );
res.write( '<?xml-stylesheet href="/static/result.css"?>\n' );
--
To view, visit https://gerrit.wikimedia.org/r/73985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib882ba4ece08533e645e3eba6e9a78138f6c2787
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: rt_testing
Gerrit-Owner: Marcoil <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
