Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/74002
Change subject: Cleanup and added docs ...................................................................... Cleanup and added docs Change-Id: I83b674a61eef0a085735abc90eb3fc80382a0102 --- M src/Ask/DeserializerFactory.php M src/Ask/SerializerFactory.php 2 files changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Ask refs/changes/02/74002/1 diff --git a/src/Ask/DeserializerFactory.php b/src/Ask/DeserializerFactory.php index f5cbec8..5ff0ce6 100644 --- a/src/Ask/DeserializerFactory.php +++ b/src/Ask/DeserializerFactory.php @@ -12,14 +12,17 @@ use Deserializers\DispatchingDeserializer; /** + * Factory for constructing Deserializer objects that can deserialize Ask language objects. + * All external access to the deserializers should happen through this factory! (See README) + * * @since 0.1 * * @file * @ingroup Ask * * @licence GNU GPL v2+ - * @author Jeroen De Dauw < [email protected] > * @author Adam Shorland < [email protected] > + * @author Jeroen De Dauw < [email protected] > */ class DeserializerFactory { @@ -37,8 +40,6 @@ * @return Deserializer */ public function newQueryDeserializer() { - - $dispatchingDeserializer = new DispatchingDeserializer(); $dispatchingDeserializer->addDeserializer( $this->newDescriptionDeserializer() ); @@ -90,7 +91,7 @@ * @return Deserializer */ public function newQueryOptionsDeserializer() { - return new QueryOptionsDeserializer( $this->newSortExpressionDeserializer( $this->dataValueFactory ) ); + return new QueryOptionsDeserializer( $this->newSortExpressionDeserializer() ); } } diff --git a/src/Ask/SerializerFactory.php b/src/Ask/SerializerFactory.php index 49fb46a..05bedf5 100644 --- a/src/Ask/SerializerFactory.php +++ b/src/Ask/SerializerFactory.php @@ -11,6 +11,9 @@ use Serializers\Serializer; /** + * Factory for constructing Serializer objects that can serialize Ask language objects. + * All external access to the serializers should happen through this factory! (See README) + * * @since 0.1 * * @file -- To view, visit https://gerrit.wikimedia.org/r/74002 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I83b674a61eef0a085735abc90eb3fc80382a0102 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
