Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/74109
Change subject: (bug 51493) handle invalid json snak data in SetReference api
module
......................................................................
(bug 51493) handle invalid json snak data in SetReference api module
Change-Id: I72f9410642edcca9fe2459b325726e979ec4d814
---
M repo/includes/api/SetReference.php
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/09/74109/1
diff --git a/repo/includes/api/SetReference.php
b/repo/includes/api/SetReference.php
index 311837f..ec9f871 100644
--- a/repo/includes/api/SetReference.php
+++ b/repo/includes/api/SetReference.php
@@ -158,6 +158,10 @@
$this->dieUsage( 'Invalid snak JSON
given', 'invalid-json' );
}
foreach ( $byPropertySnaks as $rawSnak ) {
+ if ( !is_array( $rawSnak ) ) {
+ $this->dieUsage( 'Invalid snak
JSON given', 'invalid-json' );
+ }
+
$snak =
$snakUnserializer->newFromSerialization( $rawSnak );
$this->snakValidation->validateSnak(
$snak );
$snaks[] = $snak;
--
To view, visit https://gerrit.wikimedia.org/r/74109
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I72f9410642edcca9fe2459b325726e979ec4d814
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
