Milimetric has submitted this change and it was merged.
Change subject: small jobs usability fix
......................................................................
small jobs usability fix
Change-Id: I0833eaeaff7915414301799dcfa6561019b2d554
---
M wikimetrics/static/js/site.js
M wikimetrics/templates/jobs.html
2 files changed, 16 insertions(+), 3 deletions(-)
Approvals:
Milimetric: Verified; Looks good to me, approved
diff --git a/wikimetrics/static/js/site.js b/wikimetrics/static/js/site.js
index 9160fdd..f1283dc 100644
--- a/wikimetrics/static/js/site.js
+++ b/wikimetrics/static/js/site.js
@@ -74,7 +74,20 @@
populateJobs: function(viewModel){
$.get('/jobs/list/', function(data){
- viewModel.jobs(data.jobs);
+ jobs = viewModel.jobs();
+ jobsDict = {};
+ for(j in jobs){
+ jobsDict[jobs[j].id] = jobs[j];
+ }
+ for(dj in data.jobs){
+ job = data.jobs[dj];
+ if (job.id in jobsDict && job.status ===
jobsDict[job.id].status){
+ continue;
+ }
+ // if there's a difference, just replace the whole thing
+ viewModel.jobs(data.jobs);
+ return;
+ }
}).fail(site.failure);
},
};
diff --git a/wikimetrics/templates/jobs.html b/wikimetrics/templates/jobs.html
index 3ab92b9..79036d0 100644
--- a/wikimetrics/templates/jobs.html
+++ b/wikimetrics/templates/jobs.html
@@ -31,8 +31,8 @@
<span class="caret"></span>
</button>
<ul class="dropdown-menu">
- <li><a data-bind="attr: {href: '/jobs/result/' + id +
'.json'}">JSON</a></li>
- <li><a data-bind="attr: {href: '/jobs/result/' + id +
'.csv'}">CSV</a></li>
+ <li><a target="_blank" data-bind="attr: {href:
'/jobs/result/' + id + '.json'}">JSON</a></li>
+ <li><a target="_blank" data-bind="attr: {href:
'/jobs/result/' + id + '.csv'}">CSV</a></li>
</ul>
</div>
</td>
--
To view, visit https://gerrit.wikimedia.org/r/74177
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0833eaeaff7915414301799dcfa6561019b2d554
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wikimetrics
Gerrit-Branch: master
Gerrit-Owner: Milimetric <[email protected]>
Gerrit-Reviewer: Milimetric <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
