Mwalker has submitted this change and it was merged.
Change subject: log if we cannot insert a contribution_tracking record
......................................................................
log if we cannot insert a contribution_tracking record
Change-Id: I4ad49f3571398aa6e88c3458b7632629b62c73d5
---
M gateway_common/DonationData.php
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Mwalker: Looks good to me, approved
diff --git a/gateway_common/DonationData.php b/gateway_common/DonationData.php
index 7348355..c2d0edd 100644
--- a/gateway_common/DonationData.php
+++ b/gateway_common/DonationData.php
@@ -1186,7 +1186,7 @@
$tracked_contribution = $this->getCleanTrackingData();
// insert tracking data and get the tracking id
- $result = self::insertContributionTracking(
$tracked_contribution );
+ $result = $this->insertContributionTracking(
$tracked_contribution );
$this->setVal( 'contribution_tracking_id', $result );
@@ -1202,9 +1202,10 @@
* @param array $tracking_data The array of tracking data to insert to
contribution_tracking
* @return mixed Contribution tracking ID or false on failure
*/
- public static function insertContributionTracking( $tracking_data ) {
+ public function insertContributionTracking( $tracking_data ) {
$db =
ContributionTrackingProcessor::contributionTrackingConnection();
+ // FIXME: impossible condition.
if ( !$db ) {
return false;
}
@@ -1218,6 +1219,7 @@
if ( $db->insert( 'contribution_tracking', $tracking_data ) ) {
return $db->insertId();
} else {
+ $this->log( $this->getLogMessagePrefix() . 'Failed to
create a new contribution_tracking record', LOG_ERR );
return false;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/74184
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ad49f3571398aa6e88c3458b7632629b62c73d5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Adamw <[email protected]>
Gerrit-Reviewer: Mwalker <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
