jenkins-bot has submitted this change and it was merged.
Change subject: Fix getAnnotationIndexesFromOffset for last offset in doc
......................................................................
Fix getAnnotationIndexesFromOffset for last offset in doc
If the element is undefined, it would stand to reason that there are no
annotations there.
Just sayin'.
Change-Id: I2b66e7adc2b3af19df1a3f490ab479627807636e
---
M modules/ve/dm/lineardata/ve.dm.ElementLinearData.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/dm/lineardata/ve.dm.ElementLinearData.js
b/modules/ve/dm/lineardata/ve.dm.ElementLinearData.js
index 1e2dc2a..b2a3211 100644
--- a/modules/ve/dm/lineardata/ve.dm.ElementLinearData.js
+++ b/modules/ve/dm/lineardata/ve.dm.ElementLinearData.js
@@ -307,7 +307,7 @@
element = this.getData( offset );
}
- if ( typeof element === 'string' ) {
+ if ( element === undefined || typeof element === 'string' ) {
return [];
} else {
return element.annotations || element[1] || [];
--
To view, visit https://gerrit.wikimedia.org/r/74189
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b66e7adc2b3af19df1a3f490ab479627807636e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
