Milimetric has submitted this change and it was merged.
Change subject: disabling non-ubiquitous revision table columns and a minor ui
fix
......................................................................
disabling non-ubiquitous revision table columns and a minor ui fix
Change-Id: Ia37121a6cb0ac56cfd7d672a2501b84cbf59f822
---
M wikimetrics/models/mediawiki/revision.py
M wikimetrics/static/js/cohortList.js
M wikimetrics/templates/cohorts.html
3 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Milimetric: Verified; Looks good to me, approved
diff --git a/wikimetrics/models/mediawiki/revision.py
b/wikimetrics/models/mediawiki/revision.py
index 436492c..10f3d82 100644
--- a/wikimetrics/models/mediawiki/revision.py
+++ b/wikimetrics/models/mediawiki/revision.py
@@ -21,5 +21,5 @@
rev_len = Column(Integer)
rev_parent_id = Column(Integer)
rev_sha1 = Column(String(32))
- rev_content_model = Column(String(32))
- rev_content_format = Column(String(64))
+ #rev_content_model = Column(String(32))
+ #rev_content_format = Column(String(64))
diff --git a/wikimetrics/static/js/cohortList.js
b/wikimetrics/static/js/cohortList.js
index 503ce93..fe4bb0f 100644
--- a/wikimetrics/static/js/cohortList.js
+++ b/wikimetrics/static/js/cohortList.js
@@ -28,6 +28,7 @@
.done(site.handleWith(function(data){
setWikiusers(data.cohorts);
viewModel.cohorts(data.cohorts);
+ $('ul.nav-tabs li a').first().click();
}))
.fail(site.failure);
diff --git a/wikimetrics/templates/cohorts.html
b/wikimetrics/templates/cohorts.html
index 3ce48b1..4f3c2d1 100644
--- a/wikimetrics/templates/cohorts.html
+++ b/wikimetrics/templates/cohorts.html
@@ -12,13 +12,12 @@
<hr/>
<div class="tabbable tabs-left">
<ul class="nav nav-tabs" data-bind="foreach: cohorts">
- <li data-bind="css: {active: $index == 0}">
- <a data-bind="text: name, attr: {href: '#' + id}, click: $root.view"
- data-toggle="tab"></a>
+ <li>
+ <a data-bind="text: name, attr: {href: '#' + id}, click:
$root.view" data-toggle="tab"></a>
</li>
</ul>
<div class="tab-content" data-bind="foreach: cohorts">
- <div class="tab-pane" data-bind="attr: {id: id}, css: {active: $index
=== 0}">
+ <div class="tab-pane" data-bind="attr: {id: id}">
<div class="hero-unit">
<h5 data-bind="text: name"></h5>
<p data-bind="text: description"></p>
--
To view, visit https://gerrit.wikimedia.org/r/74257
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia37121a6cb0ac56cfd7d672a2501b84cbf59f822
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wikimetrics
Gerrit-Branch: master
Gerrit-Owner: Milimetric <[email protected]>
Gerrit-Reviewer: Milimetric <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
