Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/74390
Change subject: If nothin to migrate, print a message to inform user.
......................................................................
If nothin to migrate, print a message to inform user.
If there is nothing to migrate, the migration script should tell the user so,
rather than exit quietly. This patch fixes that and replaces an echo statement
with Maintenance::output (which is '--quiet'-aware).
Change-Id: Id89fbba166df626c9c70df5d6272cc38a61e3dbb
---
M maintenance/migrateCampaigns.php
1 file changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard
refs/changes/90/74390/1
diff --git a/maintenance/migrateCampaigns.php b/maintenance/migrateCampaigns.php
index fb7ba77..dffd5b2 100644
--- a/maintenance/migrateCampaigns.php
+++ b/maintenance/migrateCampaigns.php
@@ -223,7 +223,12 @@
'uw_campaigns',
'*'
);
-
+
+ if ( !$campaigns->numRows() ) {
+ $this->output( "Nothing to migrate.\n" );
+ return;
+ }
+
foreach ( $campaigns as $campaign ) {
$oldConfig = $this->getConfigFromDB(
$campaign->campaign_id );
$newConfig = $this->getConfigForJSON( $campaign,
$oldConfig );
@@ -232,13 +237,13 @@
$page = Wikipage::factory( $title );
$content = new CampaignContent( json_encode( $newConfig
) );
- $status = $page->doEditContent(
- $content,
+ $status = $page->doEditContent(
+ $content,
"Migrating from old campaign tables",
0, false,
User::newFromName( $user )
);
- echo "Migrated " . $campaign->campaign_name . "\n";
+ $this->output( "Migrated " . $campaign->campaign_name .
"\n" );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/74390
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id89fbba166df626c9c70df5d6272cc38a61e3dbb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
