Milimetric has submitted this change and it was merged.
Change subject: fix link to show up for invalid records
......................................................................
fix link to show up for invalid records
Change-Id: I075b8456092301f5b1fac011319f6286a321de73
---
M wikimetrics/controllers/cohorts.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Milimetric: Verified; Looks good to me, approved
diff --git a/wikimetrics/controllers/cohorts.py
b/wikimetrics/controllers/cohorts.py
index 5542e7f..83d99d6 100644
--- a/wikimetrics/controllers/cohorts.py
+++ b/wikimetrics/controllers/cohorts.py
@@ -368,8 +368,10 @@
valid = []
invalid = []
for record in records:
- record['user_str'] = record['username']
normalized_project = normalize_project(record['project'])
+ link_project = normalized_project or record['project'] or 'invalid'
+ record['user_str'] = record['username']
+ record['link'] = link_to_user_page(record['username'], link_project)
if normalized_project is None:
record['reason_invalid'] = 'invalid project: %s' %
record['project']
invalid.append(record)
@@ -377,7 +379,6 @@
normalized_user = normalize_user(record['user_str'],
normalized_project)
# make a link to the potential user page even if user doesn't exist
# this gives a chance to see any misspelling etc.
- record['link'] = link_to_user_page(record['username'],
normalized_project)
if normalized_user is None:
logging.debug('invalid: %s', record['user_str'])
record['reason_invalid'] = 'invalid user_name / user_id: %s' %
record['user_str']
--
To view, visit https://gerrit.wikimedia.org/r/74397
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I075b8456092301f5b1fac011319f6286a321de73
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wikimetrics
Gerrit-Branch: master
Gerrit-Owner: Milimetric <[email protected]>
Gerrit-Reviewer: Milimetric <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
