jenkins-bot has submitted this change and it was merged.
Change subject: Bug 51480: Add placeholder text to textarea
......................................................................
Bug 51480: Add placeholder text to textarea
Challenge the user to edit it!
Bug: 51480
Change-Id: I0111600a031e53f035d1261f17ea11b32077686e
---
M MobileFrontend.i18n.php
M includes/Resources.php
M javascripts/modules/editor/EditorOverlay.js
M templates/overlays/editor.html
4 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
JGonera: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MobileFrontend.i18n.php b/MobileFrontend.i18n.php
index e0f8ae3..fc91daa 100644
--- a/MobileFrontend.i18n.php
+++ b/MobileFrontend.i18n.php
@@ -251,6 +251,7 @@
'mobile-frontend-editor-cancel' => 'Cancel',
'mobile-frontend-editor-keep-editing' => 'Keep editing',
'mobile-frontend-editor-license' => 'By clicking "Save", you agree to
our [//wikimediafoundation.org/wiki/Terms_of_use Terms of Use] and agree to
release your text under the [//creativecommons.org/licenses/by-sa/3.0/ Creative
Commons Attribution-ShareAlike 3.0 License].',
+ 'mobile-frontend-editor-placeholder' => 'This section is empty. Be the
first to expand it!',
'mobile-frontend-editor-summary-placeholder' => 'Tell us what you
changed (optional)',
'mobile-frontend-editor-cancel-confirm' => 'Do you really want to
abandon your edit?',
'mobile-frontend-editor-wait' => 'Saving edit, please wait.',
@@ -685,6 +686,7 @@
See also:
* {{msg-mw|Mobile-frontend-editor-save}}',
+ 'mobile-frontend-editor-placeholder' => 'Placeholder text for empty
sections.',
'mobile-frontend-editor-summary-placeholder' => 'A placeholder for the
summary input field asking user what they changed (the field is optional).',
'mobile-frontend-editor-cancel-confirm' => 'Question asking user if
they are positive about abandoning unsaved edit.',
'mobile-frontend-editor-wait' => 'Text that displays while a page edit
is being saved.',
diff --git a/includes/Resources.php b/includes/Resources.php
index 4d4d074..212680c 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -219,6 +219,7 @@
'mobile-frontend-editor-cancel',
'mobile-frontend-editor-keep-editing',
'mobile-frontend-editor-license' => array( 'parse' ),
+ 'mobile-frontend-editor-placeholder',
'mobile-frontend-editor-summary-placeholder',
'mobile-frontend-editor-cancel-confirm',
'mobile-frontend-editor-wait',
diff --git a/javascripts/modules/editor/EditorOverlay.js
b/javascripts/modules/editor/EditorOverlay.js
index 845beb4..acebf40 100644
--- a/javascripts/modules/editor/EditorOverlay.js
+++ b/javascripts/modules/editor/EditorOverlay.js
@@ -17,6 +17,7 @@
keepEditingMsg: mw.msg(
'mobile-frontend-editor-keep-editing' ),
summaryMsg: mw.msg(
'mobile-frontend-editor-summary-placeholder' ),
licenseMsg: mw.msg( 'mobile-frontend-editor-license' ),
+ placeholder: mw.msg(
'mobile-frontend-editor-placeholder' ),
previewMsg: mw.msg(
'mobile-frontend-editor-preview-header' ),
waitMsg: mw.msg( 'mobile-frontend-editor-wait' ),
guiderMsg: mw.msg( 'mobile-frontend-editor-guider' )
diff --git a/templates/overlays/editor.html b/templates/overlays/editor.html
index a1df475..59f9176 100644
--- a/templates/overlays/editor.html
+++ b/templates/overlays/editor.html
@@ -2,7 +2,7 @@
<button class="cancel">{{closeMsg}}</button>
</div>
<div class="spinner loading"></div>
-<textarea cols="40" rows="10"></textarea>
+<textarea cols="40" rows="10" placeholder="{{placeholder}}"></textarea>
<div class="preview">
<h2>{{previewMsg}}</h2>
<div class="content"></div>
--
To view, visit https://gerrit.wikimedia.org/r/74392
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0111600a031e53f035d1261f17ea11b32077686e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
