Matmarex has uploaded a new change for review.
https://gerrit.wikimedia.org/r/74484
Change subject: SpecialCentralAutoLogin: Inline JavaScript cleanup
......................................................................
SpecialCentralAutoLogin: Inline JavaScript cleanup
* "window." is superfluous
* use "mediaWiki" as it is the "canonical" name for the global
* avoid escaping quotes
Change-Id: I4ee545f796f36456c19b06f0e66c834c67c05b98
---
M specials/SpecialCentralAutoLogin.php
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth
refs/changes/84/74484/1
diff --git a/specials/SpecialCentralAutoLogin.php
b/specials/SpecialCentralAutoLogin.php
index 895b342..39e9e7d 100644
--- a/specials/SpecialCentralAutoLogin.php
+++ b/specials/SpecialCentralAutoLogin.php
@@ -282,15 +282,15 @@
// This is also hacky.
$script .= Xml::encodeJsCall(
- 'window.jQuery( \'#p-personal ul\' ).html',
+ "jQuery( '#p-personal ul' ).html",
array( $html )
);
// Sigh.
- $script .= 'window.jQuery( \'#p-personal\' ).addClass(
\'centralAuthPPersonalAnimation\' );';
+ $script .= "jQuery( '#p-personal' ).addClass(
'centralAuthPPersonalAnimation' );";
// Fire a hook for other extensions to listen for
- $script .= 'mw.hook( \'centralauth-p-personal-reset\'
).fire();';
+ $script .= "mediaWiki.hook(
'centralauth-p-personal-reset' ).fire();";
if ( CentralAuthHooks::isUIReloadRecommended(
$this->getUser() ) ) {
$gender = $this->getUser()->getOption( 'gender'
);
@@ -305,14 +305,14 @@
$code = $this->getUser()->getOption( 'language'
);
$code = RequestContext::sanitizeLangCode( $code
);
wfRunHooks( 'UserGetLanguageObject', array(
$this->getUser(), &$code, $this->getContext() ) );
- $script .= Xml::encodeJsCall(
'window.mediaWiki.messages.set', array(
+ $script .= Xml::encodeJsCall(
'mediaWiki.messages.set', array(
'centralauth-centralautologin-logged-in',
wfMessage(
'centralauth-centralautologin-logged-in' )
->inLanguage( $code )->plain()
) );
- $script .= Xml::encodeJsCall(
'window.mediaWiki.notify', array(
- new XmlJsCode( trim( Xml::encodeJsCall(
'window.mediaWiki.message', array(
+ $script .= Xml::encodeJsCall(
'mediaWiki.notify', array(
+ new XmlJsCode( trim( Xml::encodeJsCall(
'mediaWiki.message', array(
'centralauth-centralautologin-logged-in',
$this->getUser()->getName(),
$gender
--
To view, visit https://gerrit.wikimedia.org/r/74484
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ee545f796f36456c19b06f0e66c834c67c05b98
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Matmarex <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
