Milimetric has submitted this change and it was merged.
Change subject: bytes added between clause was broken
......................................................................
bytes added between clause was broken
Change-Id: I9c9b11939030821ef7b905ee4ecbd00b17431cc9
---
M wikimetrics/metrics/bytes_added.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Milimetric: Verified; Looks good to me, approved
diff --git a/wikimetrics/metrics/bytes_added.py
b/wikimetrics/metrics/bytes_added.py
index 62bf6fb..84fda7e 100644
--- a/wikimetrics/metrics/bytes_added.py
+++ b/wikimetrics/metrics/bytes_added.py
@@ -104,8 +104,11 @@
.outerjoin(PreviousRevision, Revision.rev_parent_id ==
PreviousRevision.c.rev_id)\
.filter(Page.page_namespace.in_(self.namespaces.data))\
.filter(Revision.rev_user.in_(user_ids))\
- .filter(between(Revision.rev_timestamp, self.start_date.data,
self.end_date.data))\
+ .filter(Revision.rev_timestamp >= self.start_date.data)\
+ .filter(Revision.rev_timestamp <= self.end_date.data)\
.subquery()
+ # TODO: figure out why between isn't quite working with these
timestamps
+ #.filter(between(Revision.rev_timestamp, self.start_date.data,
self.end_date.data))\
bytes_added_by_user = session.query(
BC.c.rev_user,
--
To view, visit https://gerrit.wikimedia.org/r/74554
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c9b11939030821ef7b905ee4ecbd00b17431cc9
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wikimetrics
Gerrit-Branch: master
Gerrit-Owner: Milimetric <[email protected]>
Gerrit-Reviewer: Milimetric <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
