Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/74578


Change subject: User: Perform ignoreHidden check before searching for name
......................................................................

User: Perform ignoreHidden check before searching for name

Change-Id: Icb1aab8cd8dc15387d199bb51ca2cd72de6dba88
---
M includes/User.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/78/74578/1

diff --git a/includes/User.php b/includes/User.php
index 685bce7..b09d79c 100644
--- a/includes/User.php
+++ b/includes/User.php
@@ -2292,7 +2292,7 @@
                # set it, and then it was disabled removing their ability to 
change it).  But
                # we don't want to erase the preferences in the database in 
case the preference
                # is re-enabled again.  So don't touch $mOptions, just override 
the returned value
-               if ( in_array( $oname, $wgHiddenPrefs ) && !$ignoreHidden ) {
+               if ( !$ignoreHidden && in_array( $oname, $wgHiddenPrefs ) ) {
                        return self::getDefaultOption( $oname );
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/74578
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb1aab8cd8dc15387d199bb51ca2cd72de6dba88
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to