jenkins-bot has submitted this change and it was merged.
Change subject: Bug 50765: Allow content case modification in simple links
......................................................................
Bug 50765: Allow content case modification in simple links
Use the content for simple wikilinks if the content was modified. Change
detection for the content only works with selser enabled, which makes this
hard to test.
Change-Id: I276d573c445b0b7302aae8f55aea92cc0377a2d7
---
M js/lib/mediawiki.WikitextSerializer.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/js/lib/mediawiki.WikitextSerializer.js
b/js/lib/mediawiki.WikitextSerializer.js
index bf5e207..d7ccb84 100644
--- a/js/lib/mediawiki.WikitextSerializer.js
+++ b/js/lib/mediawiki.WikitextSerializer.js
@@ -1137,6 +1137,8 @@
rtData.target = DU.getAttributeShadowInfo(node, 'href', tplAttrs);
// Check if the link content has been modified
+ // FIXME: This will only work with selser of course. Hard to test
without
+ // selser.
DU.loadDataAttrib(node, "parsoid-diff", {});
var changes = node.data['parsoid-diff'].diff || [];
if (changes.indexOf('subtree-changed') !== -1) {
@@ -1780,7 +1782,7 @@
if ( canUseSimple ) {
// Simple case
- if (!target.modified) {
+ if (!target.modified &&
!linkData.contentModified) {
linkTarget = target.value;
} else {
linkTarget =
escapeWikiLinkContentString(linkData.content.string, state,
linkData.contentNode);
--
To view, visit https://gerrit.wikimedia.org/r/74561
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I276d573c445b0b7302aae8f55aea92cc0377a2d7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
