Subramanya Sastry has uploaded a new change for review.
https://gerrit.wikimedia.org/r/74579
Change subject: Clone object if frozen before setting tagId
......................................................................
Clone object if frozen before setting tagId
* Fixes crashers in RT testing
Tried on fr:Cathédrale_Saint-Jean_de_Besançon
Change-Id: Ibcfac1eef7b8293a9dbbd6c68cf2487cb0308061
---
M js/lib/mediawiki.HTML5TreeBuilder.node.js
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid
refs/changes/79/74579/1
diff --git a/js/lib/mediawiki.HTML5TreeBuilder.node.js
b/js/lib/mediawiki.HTML5TreeBuilder.node.js
index 7bf6ae0..5bf7b7a 100644
--- a/js/lib/mediawiki.HTML5TreeBuilder.node.js
+++ b/js/lib/mediawiki.HTML5TreeBuilder.node.js
@@ -8,7 +8,8 @@
var events = require('events'),
$ = require( './fakejquery' ),
HTML5 = require('./html5/index'),
- defines = require('./mediawiki.parser.defines.js');
+ defines = require('./mediawiki.parser.defines.js'),
+ Util = require('./mediawiki.Util.js').Util;
// define some constructor shortcuts
var CommentTk = defines.CommentTk,
EOFTk = defines.EOFTk,
@@ -109,6 +110,9 @@
}
// Assign tagid for open tags
if (token.constructor === TagTk && token.name !== 'body') {
+ if (Object.isFrozen(dataAttribs)) {
+ dataAttribs = Util.clone(dataAttribs);
+ }
dataAttribs.tagId = this.tagId++;
}
--
To view, visit https://gerrit.wikimedia.org/r/74579
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibcfac1eef7b8293a9dbbd6c68cf2487cb0308061
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
