jenkins-bot has submitted this change and it was merged.
Change subject: Fixing data item link Selenium test
......................................................................
Fixing data item link Selenium test
Change-Id: Ifaf44671118821d85807c0d074c27f50f9494803
---
M client/tests/selenium/interwiki/client_repo_spec.rb
M client/tests/selenium/interwiki/interwiki_spec.rb
2 files changed, 11 insertions(+), 9 deletions(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
jenkins-bot: Verified
diff --git a/client/tests/selenium/interwiki/client_repo_spec.rb
b/client/tests/selenium/interwiki/client_repo_spec.rb
index 8000fb1..1ca8f2c 100644
--- a/client/tests/selenium/interwiki/client_repo_spec.rb
+++ b/client/tests/selenium/interwiki/client_repo_spec.rb
@@ -38,15 +38,6 @@
page.interwiki_xxx?.should be_false
end
end
- it "should check data item link in client toolbox" do
- on_page(ClientPage) do |page|
- page.navigate_to_article(article_title_a)
- page.clientDataItemLink?.should be_true
- page.clientDataItemLink
- page.wait_for_entity_to_load
- page.entityLabelSpan.should == article_title_a
- end
- end
it "should login as user & add some sitelinks to the item" do
visit_page(RepoLoginPage) do |page|
page.login_with(WIKI_ADMIN_USERNAME, WIKI_ADMIN_PASSWORD)
diff --git a/client/tests/selenium/interwiki/interwiki_spec.rb
b/client/tests/selenium/interwiki/interwiki_spec.rb
index 029b2d9..97f4766 100644
--- a/client/tests/selenium/interwiki/interwiki_spec.rb
+++ b/client/tests/selenium/interwiki/interwiki_spec.rb
@@ -54,6 +54,17 @@
page.entityDescriptionSpan.should == item_description
end
end
+ it "should check data item link in client toolbox" do
+ on_page(ClientPage) do |page|
+ page.navigate_to_article(article_title)
+ page.clientDataItemLink?.should be_true
+ page.clientDataItemLink
+ end
+ on_page(ItemPage) do |page|
+ page.wait_for_entity_to_load
+ page.entityLabelSpan.should == article_title
+ end
+ end
end
context "Check noexternallanglinks magic word behavior" do
--
To view, visit https://gerrit.wikimedia.org/r/74600
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifaf44671118821d85807c0d074c27f50f9494803
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
