Cmcmahon has uploaded a new change for review.
https://gerrit.wikimedia.org/r/74640
Change subject: Maintenance update for References test
......................................................................
Maintenance update for References test
Change-Id: I216064273242d058f5140c38d4495d2b52a4c38e
---
M features/step_definitions/visual_editor_references_steps.rb
M features/support/pages/visual_editor_page.rb
M features/visual_editor_references.feature
3 files changed, 8 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests
refs/changes/40/74640/1
diff --git a/features/step_definitions/visual_editor_references_steps.rb
b/features/step_definitions/visual_editor_references_steps.rb
index 52e420a..c61eff7 100644
--- a/features/step_definitions/visual_editor_references_steps.rb
+++ b/features/step_definitions/visual_editor_references_steps.rb
@@ -1,8 +1,8 @@
Given(/^I can see the References User Interface$/) do
- on(VisualEditorPage).ref_body.should match Regexp.escape('Insert reference')
+ on(VisualEditorPage).ref_body.should match Regexp.escape('Reference')
end
-When(/^I click Create new source$/) do
+When(/^I click Insert reference$/) do
sleep 2 #fix for Chrome see
https://code.google.com/p/selenium/issues/detail?id=2766
on(VisualEditorPage).create_new_element.when_present.click
end
@@ -24,8 +24,7 @@
on(VisualEditorPage).insert_reference_element.should be_visible
end
-Then(/^I should see the second Apply changes button$/) do
- sleep 2
- on(VisualEditorPage).apply_changes_new_frame_element.should be_visible
+Then(/^link to references dialog should be visible$/) do
+ on(VisualEditorPage).refs_link_element.should be_visible
end
diff --git a/features/support/pages/visual_editor_page.rb
b/features/support/pages/visual_editor_page.rb
index d07a006..62e1ce1 100644
--- a/features/support/pages/visual_editor_page.rb
+++ b/features/support/pages/visual_editor_page.rb
@@ -13,6 +13,7 @@
span(:looks_good, class: 've-ui-labeledElement-label', text: 'Looks good to
me')
checkbox(:minor_edit, id: 've-init-mw-viewPageTarget-saveDialog-minorEdit')
div(:page_text, id: 'mw-content-text')
+ a(:refs_link, title: 'Reference')
span(:return_to_save, class: 've-ui-labeledElement-label', text: 'Return to
save form')
span(:review_changes, class: 've-ui-labeledElement-label', text: 'Review
your changes')
div(:save_disabled, class: 've-ui-widget ve-ui-widget-disabled
ve-ui-flaggableElement-constructive ve-ui-buttonWidget')
@@ -27,7 +28,7 @@
span(:add_template, text: 'Add template', frame: frame)
span(:apply_changes, text: 'Apply changes', frame: frame)
text_field(:content_box, index: 0, frame: frame)
- span(:create_new, text:'Create new source', frame: frame)
+ span(:create_new, text:'Insert reference', frame: frame)
div(:insert_reference, class: 've-ui-widget ve-ui-flaggableElement-primary
ve-ui-buttonWidget ve-ui-window-applyButton', frame: frame)
a(:leftarrowclose, class: 've-ui-widget ve-ui-iconButtonWidget
ve-ui-icon-previous ve-ui-inspector-closeButton', frame: frame)
span(:linksuggestion, text: 'http://www.example.com')
@@ -40,9 +41,5 @@
list_item(:template_list_item, text: 'S', frame: frame)
div(:title, class: 've-ui-window-title', frame: frame)
text_area(:transclusion_textarea, index: 0, frame: frame)
- end
-
- in_frame(:index => 1) do |frame|
- span(:apply_changes_new_frame, text: 'Apply changes', frame: frame)
end
end
diff --git a/features/visual_editor_references.feature
b/features/visual_editor_references.feature
index 1eeaf2e..c0205f8 100644
--- a/features/visual_editor_references.feature
+++ b/features/visual_editor_references.feature
@@ -10,5 +10,5 @@
Scenario: Type into boxes
Given I can see the References User Interface
When I enter THIS IS CONTENT into Content box
- And I click Create new source
- Then I should see the second Apply changes button
+ And I click Insert reference
+ Then link to references dialog should be visible
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/74640
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I216064273242d058f5140c38d4495d2b52a4c38e
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
