Matmarex has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/74660


Change subject: Special:ListGroupRights: Display the legend at the top
......................................................................

Special:ListGroupRights: Display the legend at the top

Previously it was displayed at the bottom and was rather hard to notice.

Also prefix the legend with "Legend:" to make the interface clearer.

Change-Id: I62f3dfb311ae648180363f36d60a5f400ea4f077
---
M includes/specials/SpecialListgrouprights.php
M languages/messages/MessagesEn.php
2 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/60/74660/1

diff --git a/includes/specials/SpecialListgrouprights.php 
b/includes/specials/SpecialListgrouprights.php
index 57bfea5..82a4f70 100644
--- a/includes/specials/SpecialListgrouprights.php
+++ b/includes/specials/SpecialListgrouprights.php
@@ -50,6 +50,8 @@
                $out = $this->getOutput();
                $out->addModuleStyles( 'mediawiki.special' );
 
+               $out->wrapWikiMsg( "<div 
class=\"mw-listgrouprights-key\">\n$1\n</div>", 'listgrouprights-key' );
+
                $out->addHTML(
                        Xml::openElement( 'table', array( 'class' => 'wikitable 
mw-listgrouprights-table' ) ) .
                                '<tr>' .
@@ -129,10 +131,7 @@
                                '
                        ) );
                }
-               $out->addHTML(
-                       Xml::closeElement( 'table' ) . "\n<br /><hr />\n"
-               );
-               $out->wrapWikiMsg( "<div 
class=\"mw-listgrouprights-key\">\n$1\n</div>", 'listgrouprights-key' );
+               $out->addHTML( Xml::closeElement( 'table' ) );
        }
 
        /**
diff --git a/languages/messages/MessagesEn.php 
b/languages/messages/MessagesEn.php
index b8a927c..c68de09 100644
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -2867,7 +2867,8 @@
 'listgrouprights'                      => 'User group rights',
 'listgrouprights-summary'              => 'The following is a list of user 
groups defined on this wiki, with their associated access rights.
 There may be [[{{MediaWiki:Listgrouprights-helppage}}|additional information]] 
about individual rights.',
-'listgrouprights-key'                  => '* <span 
class="listgrouprights-granted">Granted right</span>
+'listgrouprights-key'                  => 'Legend:
+* <span class="listgrouprights-granted">Granted right</span>
 * <span class="listgrouprights-revoked">Revoked right</span>',
 'listgrouprights-group'                => 'Group',
 'listgrouprights-rights'               => 'Rights',

-- 
To view, visit https://gerrit.wikimedia.org/r/74660
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I62f3dfb311ae648180363f36d60a5f400ea4f077
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matmarex <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to