Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/74813
Change subject: Hygiene: Start enforcing modules
......................................................................
Hygiene: Start enforcing modules
This will make leakage from beta/alpha to stable more obvious
Change-Id: I7bf02628dd256cd6e30eecf9bf91ba08cc5fd22a
---
M javascripts/common/history-alpha.js
M javascripts/common/modules.js
M tests/javascripts/fixtures.js
3 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/13/74813/1
diff --git a/javascripts/common/history-alpha.js
b/javascripts/common/history-alpha.js
index 49277c2..de0bdec 100644
--- a/javascripts/common/history-alpha.js
+++ b/javascripts/common/history-alpha.js
@@ -1,4 +1,5 @@
( function( M, $ ) {
+ M.assert( [ 'alpha' ] );
var
Page = M.require( 'page' ),
diff --git a/javascripts/common/modules.js b/javascripts/common/modules.js
index 9a64365..918acdb 100644
--- a/javascripts/common/modules.js
+++ b/javascripts/common/modules.js
@@ -1,6 +1,12 @@
mw.mobileFrontend = {
_modules: {},
+ assert: function( modes ) {
+ if ( modes.indexOf( mw.config.get( 'wgMFMode' ) ) === -1 ) {
+ throw new Error( 'Attempt to run module outside
declared environment mode' );
+ }
+ },
+
/**
* Require (import) a module previously defined using define().
*
diff --git a/tests/javascripts/fixtures.js b/tests/javascripts/fixtures.js
index e0bada5..31de835 100644
--- a/tests/javascripts/fixtures.js
+++ b/tests/javascripts/fixtures.js
@@ -1,2 +1,4 @@
// turn sinon into a global
window.sinon = sinon;
+// force alpha so all code passes M.assert
+mw.config.set( 'wgMFMode', 'alpha' );
--
To view, visit https://gerrit.wikimedia.org/r/74813
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7bf02628dd256cd6e30eecf9bf91ba08cc5fd22a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
