Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/75086
Change subject: Fix regression of I990eb6402085290df314db0a75235e0ad7b2fd55
......................................................................
Fix regression of I990eb6402085290df314db0a75235e0ad7b2fd55
There were multiple issues:
1. Selecting of input methods stopped working
2. With 'personal' position, ULS windows comes on every page click
Bug: 50559
Change-Id: I0cf815228760d27bca07acd58631713988659831
---
M resources/js/ext.uls.languagesettings.js
1 file changed, 3 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/86/75086/1
diff --git a/resources/js/ext.uls.languagesettings.js
b/resources/js/ext.uls.languagesettings.js
index 8ef3d49..d774031 100644
--- a/resources/js/ext.uls.languagesettings.js
+++ b/resources/js/ext.uls.languagesettings.js
@@ -69,11 +69,11 @@
.on( 'click', $.proxy( this.close, this ) );
// Hide the window when clicked outside
- $( 'html' ).click( $.proxy( this.close, this ) );
+ $( 'html' ).click( $.proxy( this.hide, this ) );
// ... but when clicked on window do not hide.
- this.$window.on( 'click', function () {
- return false;
+ this.$window.on( 'click', function ( e ) {
+ e.stopPropagation();
} );
},
--
To view, visit https://gerrit.wikimedia.org/r/75086
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0cf815228760d27bca07acd58631713988659831
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
