jenkins-bot has submitted this change and it was merged. Change subject: Fix regression of bf1d62ba4 ......................................................................
Fix regression of bf1d62ba4 https://gerrit.wikimedia.org/r/#/c/75076/ had multiple issues: 1. Selecting of input methods stopped working 2. With 'personal' position, ULS windows comes on every page click Bug: 50559 Change-Id: I0cf815228760d27bca07acd58631713988659831 --- M resources/js/ext.uls.languagesettings.js 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Amire80: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/js/ext.uls.languagesettings.js b/resources/js/ext.uls.languagesettings.js index 8ef3d49..d774031 100644 --- a/resources/js/ext.uls.languagesettings.js +++ b/resources/js/ext.uls.languagesettings.js @@ -69,11 +69,11 @@ .on( 'click', $.proxy( this.close, this ) ); // Hide the window when clicked outside - $( 'html' ).click( $.proxy( this.close, this ) ); + $( 'html' ).click( $.proxy( this.hide, this ) ); // ... but when clicked on window do not hide. - this.$window.on( 'click', function () { - return false; + this.$window.on( 'click', function ( e ) { + e.stopPropagation(); } ); }, -- To view, visit https://gerrit.wikimedia.org/r/75086 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cf815228760d27bca07acd58631713988659831 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Santhosh <[email protected]> Gerrit-Reviewer: Amire80 <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
