Tobias Gritschacher has submitted this change and it was merged.
Change subject: jQuery.ui.suggester: Proper event handler management
......................................................................
jQuery.ui.suggester: Proper event handler management
Handling resize event handler attached to "window" more specifically preventing
conflicts
between jQuery.ui.suggester and child widgets inheriting from the suggester
widget.
Change-Id: Iced14408763658e9c92fe2eb65e7e66ea5c5e000
---
M ValueView/resources/jquery.ui/jquery.ui.suggester.js
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Tobias Gritschacher: Verified; Looks good to me, approved
Jeroen De Dauw: Looks good to me, but someone else must approve
diff --git a/ValueView/resources/jquery.ui/jquery.ui.suggester.js
b/ValueView/resources/jquery.ui/jquery.ui.suggester.js
index db1ca3e..b7d04a6 100644
--- a/ValueView/resources/jquery.ui/jquery.ui.suggester.js
+++ b/ValueView/resources/jquery.ui/jquery.ui.suggester.js
@@ -186,9 +186,9 @@
$( window )
.off( '.' + this.widgetName )
.on( 'resize.' + this.widgetName, function( event ) {
- if ( event.originalEvent === undefined && $(
'.ui-suggester-input' ).length > 0 ) {
- $( '.ui-suggester-input' ).data(
self.widgetName ).close( {} );
- }
+ $( ':' + self.widgetBaseClass ).each( function(
i, node ) {
+ $( node ).data( self.widgetName
).close( {} );
+ } );
} );
},
@@ -197,7 +197,7 @@
*/
destroy: function() {
// about to remove the last suggester instance on the
page
- if ( $( '.ui-suggester-input' ).length === 1 ) {
+ if ( $( ':' + this.widgetBaseClass ).length === 1 ) {
$( window ).off( '.' + this.widgetName );
}
this.element.off( '.' + this.widgetName );
--
To view, visit https://gerrit.wikimedia.org/r/73937
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iced14408763658e9c92fe2eb65e7e66ea5c5e000
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
Gerrit-Reviewer: Daniel Werner <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
