jenkins-bot has submitted this change and it was merged.
Change subject: Bug 51840: removeChild() on a non-object in HtmlFormatter line
256
......................................................................
Bug 51840: removeChild() on a non-object in HtmlFormatter line 256
Change-Id: I2e3317abfba62991ec528d6d1a3e826dfd33bcb1
---
M includes/formatters/HtmlFormatter.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
JGonera: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/formatters/HtmlFormatter.php
b/includes/formatters/HtmlFormatter.php
index d52d7d9..c9485ea 100644
--- a/includes/formatters/HtmlFormatter.php
+++ b/includes/formatters/HtmlFormatter.php
@@ -253,7 +253,9 @@
private function removeElements( array $elements ) {
/** @var $element DOMElement */
foreach ( $elements as $element ) {
- $element->parentNode->removeChild( $element );
+ if ( $element->parentNode ) {
+ $element->parentNode->removeChild( $element );
+ }
}
}
--
To view, visit https://gerrit.wikimedia.org/r/75252
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e3317abfba62991ec528d6d1a3e826dfd33bcb1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
