jenkins-bot has submitted this change and it was merged.
Change subject: Ensure ve-ui-panelLayout-scrollable is actually scrollable
......................................................................
Ensure ve-ui-panelLayout-scrollable is actually scrollable
Due to CSS specificity rules the styles defined for
.ve-ui-panelLayout-scrollable and .ve-ui-panelLayout-padded in
ve.ui.Layout.css were being overriden by more general rules for
.ve-ui-pagedDialog-pagesPanel .ve-ui-panelLayout in ve.ui.Dialog.css.
Bug: 51739
Change-Id: If2d5ec3168a874eb4f856450583d6c89967513df
---
M modules/ve/ui/styles/ve.ui.Dialog.css
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Catrope: Looks good to me, but someone else must approve
Robmoen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ui/styles/ve.ui.Dialog.css
b/modules/ve/ui/styles/ve.ui.Dialog.css
index 337999f..68049ce 100644
--- a/modules/ve/ui/styles/ve.ui.Dialog.css
+++ b/modules/ve/ui/styles/ve.ui.Dialog.css
@@ -166,6 +166,14 @@
overflow: hidden;
}
+.ve-ui-pagedDialog-pagesPanel .ve-ui-panelLayout-scrollable {
+ overflow-y: auto;
+}
+
+.ve-ui-pagedDialog-pagesPanel .ve-ui-panelLayout-padded {
+ padding: 2em;
+}
+
.ve-ui-window-body .ve-ce-documentNode {
padding: 1.875em; /* 1.5/0.8 */
}
--
To view, visit https://gerrit.wikimedia.org/r/74836
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2d5ec3168a874eb4f856450583d6c89967513df
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Matmarex <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Matmarex <[email protected]>
Gerrit-Reviewer: Rillke <[email protected]>
Gerrit-Reviewer: Robmoen <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits