Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/75780
Change subject: Disable file input during upload
......................................................................
Disable file input during upload
When you currently click upload the button disappears
meaning you can't recover from a failed upload
This instead disables it and re-enables it on a failure
Change-Id: I3da47a1ab4bd4353f820ee5f4c4f76e4c0826173
---
M javascripts/modules/uploads/PhotoUploader.js
M less/common/pageactions.less
M stylesheets/common/pageactions.css
3 files changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/80/75780/1
diff --git a/javascripts/modules/uploads/PhotoUploader.js
b/javascripts/modules/uploads/PhotoUploader.js
index 33cc037..e3b05d9 100644
--- a/javascripts/modules/uploads/PhotoUploader.js
+++ b/javascripts/modules/uploads/PhotoUploader.js
@@ -262,7 +262,7 @@
var self = this;
this._super( options );
this.on( 'start', function() {
- self.$el.hide();
+ self.$el.removeClass( 'enabled' );
} ).
on( 'success', function( data ) {
popup.show( mw.msg(
'mobile-frontend-photo-upload-success-article' ), 'toast' );
@@ -277,7 +277,7 @@
} ).prependTo( '#content_0' );
} ).
on( 'error cancel', function() {
- self.$el.show();
+ self.$el.addClass( 'enabled' );
} );
}
} );
diff --git a/less/common/pageactions.less b/less/common/pageactions.less
index 88255c7..9bf5e87 100644
--- a/less/common/pageactions.less
+++ b/less/common/pageactions.less
@@ -77,7 +77,13 @@
#ca-upload {
margin-right: 19px;
background-image: url(images/pagemenu/upload-locked.png);
+ input {
+ display: none;
+ }
&.enabled {
background-image: url(images/pagemenu/upload.png);
+ input {
+ display: inherit;
+ }
}
}
diff --git a/stylesheets/common/pageactions.css
b/stylesheets/common/pageactions.css
index 8031ea8..20f0fa0 100644
--- a/stylesheets/common/pageactions.css
+++ b/stylesheets/common/pageactions.css
@@ -73,6 +73,12 @@
margin-right: 19px;
background-image: url(images/pagemenu/upload-locked.png);
}
+#ca-upload input {
+ display: none;
+}
#ca-upload.enabled {
background-image: url(images/pagemenu/upload.png);
}
+#ca-upload.enabled input {
+ display: inherit;
+}
--
To view, visit https://gerrit.wikimedia.org/r/75780
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3da47a1ab4bd4353f820ee5f4c4f76e4c0826173
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
