Mwalker has uploaded a new change for review.
https://gerrit.wikimedia.org/r/75809
Change subject: Fixing a Link Bug in CentralNotice Allocations Page
......................................................................
Fixing a Link Bug in CentralNotice Allocations Page
Links should link to the banner!
Change-Id: I12d9e1eb6338a5c77b2d07b4f7f48336306b9dc7
---
M special/SpecialBannerAllocation.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/09/75809/1
diff --git a/special/SpecialBannerAllocation.php
b/special/SpecialBannerAllocation.php
index 184d10f..9b70f87 100644
--- a/special/SpecialBannerAllocation.php
+++ b/special/SpecialBannerAllocation.php
@@ -278,7 +278,6 @@
* @return string HTML for the table
*/
public function getTable( $type, $banners ) {
- $viewBanner = $this->getTitleFor( 'CentralNoticeBanners',
"edit/$banner" );
$viewCampaign = $this->getTitleFor( 'CentralNotice' );
$htmlOut = Html::openElement( 'table',
@@ -309,6 +308,7 @@
$htmlOut .= Html::closeElement( 'td' );
// Banner name
+ $viewBanner = $this->getTitleFor(
'CentralNoticeBanners', "edit/{$banner['name']}" );
$htmlOut .= Xml::openElement( 'td', array(
'valign' => 'top' ) );
// The span class is used by bannerstats.js to
find where to insert the stats
$htmlOut .= Html::openElement( 'span',
--
To view, visit https://gerrit.wikimedia.org/r/75809
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I12d9e1eb6338a5c77b2d07b4f7f48336306b9dc7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Mwalker <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
