Tobias Gritschacher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/75848
Change subject: Slightly more meaningful autocomment for wbsetsitelink
......................................................................
Slightly more meaningful autocomment for wbsetsitelink
* it now says 'modified' instead of 'added' when a sitelink was edited
Bug: 44813
Change-Id: I9c01e856a9046d174369cb4642cb992702ae73fc
---
M docs/summaries.txt
M repo/Wikibase.i18n.php
M repo/includes/changeop/ChangeOpSiteLink.php
3 files changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/48/75848/1
diff --git a/docs/summaries.txt b/docs/summaries.txt
index f6888ed..4014edc 100644
--- a/docs/summaries.txt
+++ b/docs/summaries.txt
@@ -8,6 +8,7 @@
the first comment argument is a count, used to trigger the plural version of
the
message when needed. The second argument, if present, is a language code.
+/* wbsetsitelink-add:1|site */ linktitle
/* wbsetsitelink-set:1|site */ linktitle
/* wbsetsitelink-remove:1|site */
diff --git a/repo/Wikibase.i18n.php b/repo/Wikibase.i18n.php
index 6cd66d9..9f4d4d8 100644
--- a/repo/Wikibase.i18n.php
+++ b/repo/Wikibase.i18n.php
@@ -303,7 +303,8 @@
'wikibase-item-summary-wbsetaliases-add-remove' => 'Added and removed
[$2] {{PLURAL:$1|alias|aliases}}',
'wikibase-item-summary-wbsetaliases-add' => 'Added [$2]
{{PLURAL:$1|alias|aliases}}',
'wikibase-item-summary-wbsetaliases-remove' => 'Removed [$2]
{{PLURAL:$1|alias|aliases}}',
- 'wikibase-item-summary-wbsetsitelink-set' => 'Added link to [$2]',
+ 'wikibase-item-summary-wbsetsitelink-add' => 'Added link to [$2]',
+ 'wikibase-item-summary-wbsetsitelink-set' => 'Modified link to [$2]',
'wikibase-item-summary-wbsetsitelink-remove' => 'Removed link to [$2]',
'wikibase-item-summary-wblinktitles-create' => 'Created this item to
connect pages [$2↔$3]',
'wikibase-item-summary-wblinktitles-connect' => 'Added a language link
to connect pages [$2↔$3]',
@@ -972,7 +973,8 @@
'wikibase-item-summary-wbsetaliases-add-remove' => '{{wikibase summary
messages|item|Automatic edit summary when adding and removing item aliases. A
user can be in edit mode for aliases and can remove one or more aliases, while
adding others in the same edit.}}',
'wikibase-item-summary-wbsetaliases-add' => '{{wikibase summary
messages|item|Automatic edit summary when adding one or more aliases.}}',
'wikibase-item-summary-wbsetaliases-remove' => '{{wikibase summary
messages|item|Automatic edit summary when a user removes one or more
aliases.}}',
- 'wikibase-item-summary-wbsetsitelink-set' => '{{wikibase summary
messages|sitelinks|Automatic edit summary (autocomment) when adding or editing
a language link. Such a summary could appear in English as "Added link to
[itwiki]: Italia".}}',
+ 'wikibase-item-summary-wbsetsitelink-add' => '{{wikibase summary
messages|sitelinks|Automatic edit summary (autocomment) when adding a language
link. Such a summary could appear in English as "Added link to [itwiki]:
Italia".}}',
+ 'wikibase-item-summary-wbsetsitelink-set' => '{{wikibase summary
messages|sitelinks|Automatic edit summary (autocomment) when editing a language
link. Such a summary could appear in English as "Modified link to [itwiki]:
Italia".}}',
'wikibase-item-summary-wbsetsitelink-remove' => '{{wikibase summary
messages|sitelinks|Automatic edit summary (autocomment) when removing a
language link from a Wikidata item (page). Such a summary could appear in
English as "Removed link to [itwiki]".}}',
'wikibase-item-summary-wblinktitles-create' => '{{wikibase summary
messages|item|Automatic edit summary when connecting page(s) by creating a new
data item.}}
diff --git a/repo/includes/changeop/ChangeOpSiteLink.php
b/repo/includes/changeop/ChangeOpSiteLink.php
index 8e1c5c0..ad4029f 100644
--- a/repo/includes/changeop/ChangeOpSiteLink.php
+++ b/repo/includes/changeop/ChangeOpSiteLink.php
@@ -89,7 +89,8 @@
$entity->removeSiteLink( $this->siteId );
}
} else {
- $this->updateSummary( $summary, 'set', $this->siteId,
$this->pageName );
+ $entity->hasLinkToSite( $this->siteId ) ? $action =
'set' : $action = 'add';
+ $this->updateSummary( $summary, $action, $this->siteId,
$this->pageName );
$entity->addSimpleSiteLink( new SimpleSiteLink(
$this->siteId, $this->pageName ) );
}
--
To view, visit https://gerrit.wikimedia.org/r/75848
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c01e856a9046d174369cb4642cb992702ae73fc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
