Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/75857
Change subject: Rename 'CategoryList' to 'Category' for consistency
......................................................................
Rename 'CategoryList' to 'Category' for consistency
Change-Id: I2e3637af38b789e588ce186497238f197e5fd5d3
---
M modules/ve-mw/ui/styles/ve.ui.Widget.css
M modules/ve-mw/ui/widgets/ve.ui.MWCategoryItemWidget.js
M modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js
3 files changed, 15 insertions(+), 15 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/57/75857/1
diff --git a/modules/ve-mw/ui/styles/ve.ui.Widget.css
b/modules/ve-mw/ui/styles/ve.ui.Widget.css
index aa3ec97..4d19a02 100644
--- a/modules/ve-mw/ui/styles/ve.ui.Widget.css
+++ b/modules/ve-mw/ui/styles/ve.ui.Widget.css
@@ -29,11 +29,11 @@
/* ve.ui.MWCategoryWidget */
-.ve-ui-mwCategoryListWidget {
+.ve-ui-mwCategoryWidget {
padding: 0;
}
-.ve-ui-mwCategoryListWidget-items {
+.ve-ui-mwCategoryWidget-items {
/* MDN claims we need to use word-wrap: break-word; and that it's been
renamed to
* overflow-wrap: break-word; , but the only thing that actually works
in practice is
* word-break: break-word; (which is not documented in any standard at
all). So we just use
@@ -49,14 +49,14 @@
float: left;
}
-/* ve.ui.MWCategoryListItemWidget */
+/* ve.ui.MWCategoryItemWidget */
-.ve-ui-mwCategoryListItemWidget {
+.ve-ui-mwCategoryItemWidget {
position: relative;
float: left;
}
-.ve-ui-mwCategoryListItemButton {
+.ve-ui-mwCategoryItemButton {
position: relative;
padding: 0.5em 0.75em 0.5em 1.125em;
margin: 0.75em 0.75em 0 0;
@@ -92,23 +92,23 @@
background-image: linear-gradient(top, #ffffff 0%, #f0f0f0 100%);
}
-.ve-ui-mwCategoryListItemButton:hover {
+.ve-ui-mwCategoryItemButton:hover {
opacity: 1;
}
-.ve-ui-mwCategoryListItemButton span {
+.ve-ui-mwCategoryItemButton span {
display: block;
padding-right: 1.5em;
color: #333;
}
-.ve-ui-mwCategoryListItemButton:active {
+.ve-ui-mwCategoryItemButton:active {
border-color: #ddd;
box-shadow: inset 0 1px 4px 0 rgba(0, 0, 0, 0.07);
color: black;
}
-.ve-ui-mwCategoryListItemControl {
+.ve-ui-mwCategoryItemControl {
position: absolute;
right: 0;
top: 0;
diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryItemWidget.js
b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryItemWidget.js
index d3899dc..f9b3ee0 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryItemWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryItemWidget.js
@@ -41,12 +41,12 @@
// Initialization
this.$label.text( this.value );
- this.$arrow.addClass( 've-ui-mwCategoryListItemControl ve-ui-icon-down'
);
+ this.$arrow.addClass( 've-ui-mwCategoryItemControl ve-ui-icon-down' );
this.$categoryItem
- .addClass( 've-ui-mwCategoryListItemButton' )
+ .addClass( 've-ui-mwCategoryItemButton' )
.append( this.$label, this.$arrow, this.$$( '<div>' ).css(
'clear', 'both' ) );
this.$
- .addClass( 've-ui-mwCategoryListItemWidget' )
+ .addClass( 've-ui-mwCategoryItemWidget' )
.append( this.$categoryItem );
};
diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js
b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js
index 971debc..2bcb6f7 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js
@@ -47,9 +47,9 @@
} );
// Initialization
- this.$.addClass( 've-ui-mwCategoryListWidget' )
+ this.$.addClass( 've-ui-mwCategoryWidget' )
.append(
- this.$group.addClass(
've-ui-mwCategoryListWidget-items' ),
+ this.$group.addClass( 've-ui-mwCategoryWidget-items' ),
this.input.$,
this.$$( '<div>' ).css( 'clear', 'both' )
);
@@ -261,7 +261,7 @@
min = $input.outerWidth();
$input.css( { 'width': '100%' } );
- $lastItem = this.$.find( '.ve-ui-mwCategoryListItemWidget:last' );
+ $lastItem = this.$.find( '.ve-ui-mwCategoryItemWidget:last' );
if ( $lastItem.length ) {
// Try to fit to the right of the last item
gap = ( $input.offset().left + $input.outerWidth() ) -
--
To view, visit https://gerrit.wikimedia.org/r/75857
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e3637af38b789e588ce186497238f197e5fd5d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
