Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/75859


Change subject: Parse category names correctly
......................................................................

Parse category names correctly

Category names containing colons now parse correctly.

Bug: 51902
Change-Id: If571bb9922399c5a5f77f0b304bec3f2b6f5f7dd
---
M modules/ve-mw/ui/dialogs/ve.ui.MWMetaDialog.js
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/59/75859/1

diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWMetaDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWMetaDialog.js
index b7188d5..6f0b374 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWMetaDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWMetaDialog.js
@@ -252,9 +252,14 @@
  * @returns {Object} item
  */
 ve.ui.MWMetaDialog.prototype.getCategoryItemFromMetaListItem = function ( 
metaItem ) {
+       var title, value = '';
+       try {
+               title = new mw.Title( metaItem.element.attributes.category );
+               value = title.getMainText();
+       } catch ( e ) { }
        return {
                'name': metaItem.element.attributes.category,
-               'value': metaItem.element.attributes.category.split( ':' )[1],
+               'value': value,
                // TODO: sortkey is lcase, make consistent throughout 
CategoryWidget
                'sortKey': metaItem.element.attributes.sortkey,
                'metaItem': metaItem

-- 
To view, visit https://gerrit.wikimedia.org/r/75859
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If571bb9922399c5a5f77f0b304bec3f2b6f5f7dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to