Denny Vrandecic has uploaded a new change for review. https://gerrit.wikimedia.org/r/76022
Change subject: Removed failing test for illegal time value ...................................................................... Removed failing test for illegal time value Change-Id: Ie69992976344874e79f6c6163cd9e69c835ac3f7 --- M lib/tests/phpunit/WikibaseDataTypeBuildersTest.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/22/76022/1 diff --git a/lib/tests/phpunit/WikibaseDataTypeBuildersTest.php b/lib/tests/phpunit/WikibaseDataTypeBuildersTest.php index 5944eb9..751b093 100644 --- a/lib/tests/phpunit/WikibaseDataTypeBuildersTest.php +++ b/lib/tests/phpunit/WikibaseDataTypeBuildersTest.php @@ -122,7 +122,7 @@ //time['time'] //NOTE: The below will fail with a IllevalValueExcpetion once the TimeValue constructor enforces the time format. // Once that is done, this test and the respective validator can and should both be removed. - array( 'string', new TimeValue( '2013-06-06 11:22:33', 0, 0, 0, 0, 'http://acme.com/calendar' ), false, 'time: not ISO 8601' ), + //array( 'string', new TimeValue( '2013-06-06 11:22:33', 0, 0, 0, 0, 'http://acme.com/calendar' ), false, 'time: not ISO 8601' ), //TODO: must be an item reference //TODO: must be from a list of configured values -- To view, visit https://gerrit.wikimedia.org/r/76022 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie69992976344874e79f6c6163cd9e69c835ac3f7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Denny Vrandecic <denny.vrande...@wikimedia.de> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits