Hashar has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/76284


Change subject: style for zuul.pp
......................................................................

style for zuul.pp

Pass most puppet-lint checks and reindent to four spaces.

Change-Id: I7cb048245b6cccdaeff170a4476315c05cd7fc26
---
M manifests/role/zuul.pp
1 file changed, 43 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/84/76284/1

diff --git a/manifests/role/zuul.pp b/manifests/role/zuul.pp
index 4a99ea8..8810528 100644
--- a/manifests/role/zuul.pp
+++ b/manifests/role/zuul.pp
@@ -1,63 +1,58 @@
+# vim: set sw=4 ts=4 expandtab:
+
 # manifests/role/zuul.pp
 
 class role::zuul {
 
-       system_role { "role::zuul": description => "Zuul gating system for 
Gerrit/Jenkins" }
+    system_role { 'role::zuul': description => 'Zuul gating system for 
Gerrit/Jenkins' }
 
-       class labs {
+    class labs {
+        system_role { 'role::zuul::labs': description => 'Zuul on labs!' }
 
-               system_role { "role::zuul::labs": description => "Zuul on 
labs!" }
+        include contint::proxy_zuul
 
-               include contint::proxy_zuul
+        # Setup the instance for labs usage
+        zuulwikimedia::instance { 'zuul-labs':
+            jenkins_server   => 'http://10.4.0.172:8080/ci',
+            jenkins_user     => 'zuul',
+            gerrit_server    => '10.4.0.172',
+            gerrit_user      => 'jenkins',
+            url_pattern      => 
'http://integration.wmflabs.org/ci/job/{job.name}/{build.number}/console',
+            status_url       => 'http://integration.wmflabs.org/zuul/status',
+            git_branch       => 'labs',
+            git_dir          => '/var/lib/zuul/git',
+            push_change_refs => false,
+        }
 
-               # Setup the instance for labs usage
-               zuulwikimedia::instance { "zuul-labs":
-                       jenkins_server => 'http://10.4.0.172:8080/ci',
-                       jenkins_user => 'zuul',
-                       gerrit_server => '10.4.0.172',
-                       gerrit_user => 'jenkins',
-                       # Not enabled yet but we need a pattern anyway:
-                       #url_pattern => 
'http://jenkinslogs.wmflabs.org/{change.number}/{change.patchset}/{pipeline.name}/{job.name}/{build.number}',
-                       url_pattern => 
'http://integration.wmflabs.org/ci/job/{job.name}/{build.number}/console',
-                       status_url => 
'http://integration.wmflabs.org/zuul/status',
-                       git_branch => 'labs',
-                       git_dir => '/var/lib/zuul/git',
-                       push_change_refs => false
-               }
+    } # /role::zuul::labs
 
-       } # /role::zuul::labs
+    class production {
+        system_role { 'role::zuul::production': description => 'Zuul on 
production' }
 
-       class production {
+        # We will receive replication of git bare repositories from Gerrit
+        include role::gerrit::production::replicationdest
+        include contint::proxy_zuul
 
-               # We will receive replication of git bare repositories from 
Gerrit
-               include role::gerrit::production::replicationdest
-               include contint::proxy_zuul
+        file { '/var/lib/git':
+            ensure => 'directory',
+            owner  => 'gerritslave',
+            group  => 'root',
+            mode   => '0755',
+        }
 
-               file { "/var/lib/git":
-                       ensure => 'directory',
-                       owner => 'gerritslave',
-                       group => 'root',
-                       mode => '0755',
-               }
+        # TODO: should require Mount['/srv/ssd']
+        zuulwikimedia::instance { 'zuul-production':
+            jenkins_server   => 'http://127.0.0.1:8080/ci',
+            jenkins_user     => 'zuul-bot',
+            gerrit_server    => 'manganese.wikimedia.org',
+            gerrit_user      => 'jenkins-bot',
+            url_pattern      => 
'https://integration.wikimedia.org/ci/job/{job.name}/{build.number}/console',
+            status_url       => 'https://integration.wikimedia.org/zuul/',
+            git_branch       => 'master',
+            git_dir          => '/srv/ssd/zuul/git',
+            push_change_refs => false,
+        }
 
-               system_role { "role::zuul::production": description => "Zuul on 
production" }
-
-               # TODO: should require Mount['/srv/ssd']
-               zuulwikimedia::instance { "zuul-production":
-#                      jenkins_server => 
'https://integration.wikimedia.org/ci',
-                       jenkins_server => 'http://127.0.0.1:8080/ci',
-                       jenkins_user => 'zuul-bot',
-                       gerrit_server => 'manganese.wikimedia.org',
-                       gerrit_user => 'jenkins-bot',
-                       # Not enabled yet but we need a pattern anyway:
-                       #url_pattern => 
'https://integration.wikimedia.org/zuulreport/{change.number}/{change.patchset}/{pipeline.name}/{job.name}/{build.number}',
-                       url_pattern => 
'https://integration.wikimedia.org/ci/job/{job.name}/{build.number}/console',
-                       status_url => 'https://integration.wikimedia.org/zuul/',
-                       git_branch => 'master',
-                       git_dir => '/srv/ssd/zuul/git',
-                       push_change_refs => false
-               }
-
-       } # /role::zuul::production
+    } # /role::zuul::production
 
 } # /role::zuul

-- 
To view, visit https://gerrit.wikimedia.org/r/76284
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7cb048245b6cccdaeff170a4476315c05cd7fc26
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to